215319 - sql query fails when searching for flag requester

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect, P2)

Description

[Frank Wein [:mcsmurf]]

When i do a boolean search for "Flag Requester"->"is equal
to"->"[e-mail]" i get a software error:
Software error:

SELECT bugs.bug_id, bugs.bug_severity, bugs.priority, bugs.rep_platform,
map_assigned_to.login_name, bugs.bug_status, bugs.resolution, bugs.short_desc
FROM bugs, profiles AS map_assigned_to, flags flags_0, profiles requesters_0
LEFT JOIN bug_group_map  ON bug_group_map.bug_id = bugs.bug_id  WHERE
bugs.assigned_to = map_assigned_to.userid AND bugs.bug_id = flags_0.bug_id AND
flags_0.requester_id = requesters_0.userid AND (requesters_0.login_name =
'[e-mail]') AND ((bug_group_map.group_id IS NULL)) GROUP BY bugs.bug_id
ORDER BY bugs.bug_status,bugs.bug_id : Unknown column 'flags_0.requester_id' in
'where clause' at globals.pl line 284.

please reassign to mozilla.org/bugzilla config if this should be specific error
of bugzilla.mozilla.org

Comment 1

[Dave Miller [:justdave]]

Confirmed on landfill/bugzilla-tip.

Myk: there is no "Flag Requester" in the flags table.  It only has "Setter" and
"Requestee".  Requestee is not listed at all in the field list for the boolean
charts...  is that supposed to be Requestee instead of Requester?

Comment 2

[Vaclav Dvorak]

*** Bug 189631 has been marked as a duplicate of this bug. ***

Comment 3

[Asa Dotzler [:asa]]

So this is a mislabel in the boolean charts. We actually want "setter" and
"requestee" as options there. "requester" is a subset of "setter" and should be
gettable with a boolean search for "setter is foo" and "flag is bar?" or
something like that.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fixes problem

This patch fixes the problem by changing "requester" to "requestee" in the
appropriate places.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 158357 [details] [diff] [review]
patch v1: fixes problem

Dave, here's a simple fix for a 2.18 blocker.  Can you review?

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Thanks Dave!

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.303; previous revision: 1.302
done
Checking in Bugzilla/Search.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search.pm,v  <--  Search.pm
new revision: 1.67; previous revision: 1.66
done
Checking in ../bz218/checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.289.2.5; previous revision: 1.289.2.4
done
Checking in ../bz218/Bugzilla/Search.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search.pm,v  <--  Search.pm
new revision: 1.57.2.3; previous revision: 1.57.2.2
done