21534 - using ^k keybinding in text field causes javascript error

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[Christopher Blizzard (:blizzard)]

In any text field on unix, doing a ^k in a text field causes a javascript error:

Selection controller interface didn't work!
###!!! ASSERTION:
NS_ENSURE_TRUE(NS_SUCCEEDED(editor->DeleteSelection(nsIEditor::eToEndOfLine)))
failed: '(!((editor->DeleteSelection(nsIEditor::eToEndOfLine)) & 0x80000000))',
file nsEditorController.cpp, line 308
###!!! Break: at file nsEditorController.cpp, line 308
JavaScript Error: uncaught exception: [Exception... "Component returned failure
code: 0x80004005 (NS_ERROR_FAILURE) [nsIController.doCommand]"  nsresult:
"0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: <unknown filename> ::
onkeypress :: line 0"  data: no]

Comment 1

[karnaze (gone)]

Reassigning to Steve.

Comment 2

[buster]

assigning to akkana, who I think implemented the keybinding, and cc'ing joe, who
wrote the underlying deletion code.  Removing vidur from the cc list because I
don't think he cares.

Comment 3

[Akkana Peck]

This is a bug with the selection controller implementation -- WordMove and
IntraLineMove don't work yet.  Mike knows about it and is working on it.

Comment 4

[rubydoo123]

setting to m13

Comment 5

[Akkana Peck]

I'm taking this bug, and have found a fix.  The problem is that selection won't
handle moving when batching is on, as it is for the delete selection
transaction.  A solution is to move the selection-motion outside the batching,
and do it in nsHTMLEditor::DeleteSelection rather than in
nsEditor::CreateTxnForDeleteSelection.  I'll attach a patch, and will get Mike
to look at it tomorrow and tell me whether this is the right fix.

Comment 6

[Akkana Peck]

Marking M12 -- this is part of Mike's selection controller stuff, which is PDT+,
and the fix for this part is simple.

Comment 7

[Akkana Peck]

Attachment: Patch to make intra-line and word delete work

Comment 8

[Akkana Peck]

Fixed!

Comment 9

[Akkana Peck]

I guess it would help to check the "Fixed" box, too. :-)

Comment 10

[bsharma]

Updating QA contact.

Comment 11

[luis rincon]

Verified build 2001080708 os:linix7.1