Closed Bug 215848 Opened 22 years ago Closed 22 years ago

[mozbot.pl] Some servers reject mozbot's "Real Name" string because it contains a URL

Categories

(Webtools Graveyard :: Mozbot, defect, P5)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: zach, Assigned: ian)

Details

Some servers (such as grouch.irc.perl.org and others) will not allow mozbot to connect because it's "Real Name" string contains a url. Normally the Real Name is "[mozbot] http://mozilla.org/projects/mozbot". By default, mozbot will attempt to connect to the server, fail, and try again forever: 2003-08-11 19:10:10 UTC (5911) connecting to grouch.irc.perl.org:6667... 2003-08-11 19:10:10 UTC (5911) connected! woohoo! 2003-08-11 19:10:10 UTC (5911) adding IRC handlers (adding of handlers here) 2003-08-11 19:10:10 UTC (5911) handlers added 2003-08-11 19:10:10 UTC (5911) eek! disconnected from network Inspection with ethereal shows that the server is disconnecting us becuase of "bad user info": NICK percy USER pid-5911 foo.bar.com grouch.irc.perl.org :[mozbot] http://mozilla.org/proj$ NOTICE AUTH :*** Looking up your hostname... NOTICE AUTH :*** Checking Ident NOTICE AUTH :*** Found your hostname NOTICE AUTH :*** No Ident response ERROR :Closing Link: adsl-63-197-31-110.dsl.snfc21.pacbell.net (Bad user info) Google reveals that this can be a real-name related issue: http://www.visualirc.net/board/viewtopic.php?TopicID=1313 Upon editing mozbot.pl to just use "[mozbot]" as it's real name, it can connect normally. mozbot should probably detect these cases and alter it's real name accordingly.
I think the solution is to replace the "eek" line in mozbot.pl with: my ($reason) = $evert->args; if ($reason eq 'Bad user info') { # XXX change our IRC name to something else by setting a flag } else { &debug("eek! disconnected from network: '$reason'"); } ...and then make the Ircname stuff use that flag to decide how to form the name. However, this is totally untested.
Priority: -- → P5
Summary: Some servers reject mozbot's "Real Name" string because it contains a URL → [mozbot.pl] Some servers reject mozbot's "Real Name" string because it contains a URL
Target Milestone: --- → Mozbot 2.10
(Yes, 'eq' not '=~', unless someone can give a good reason why to expect servers to return similar-yet-not-identical strings for this.)
I checked something in, it was basically untested. Anyone got a server I can test this on?
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
QA Contact: kerz → mozbot
Target Milestone: 2.10 → 2.6
Zach: Are you still seeing this or did Hixie's patch fix it?
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.