Closed Bug 215929 Opened 21 years ago Closed 20 years ago

window title shows [object HTMLImageElement] on page with <img name="title">

Categories

(Firefox :: General, defect, P3)

x86
Windows 2000
defect

Tracking

()

RESOLVED FIXED
Firefox1.0beta

People

(Reporter: jmertic, Assigned: bugs)

References

()

Details

(Keywords: fixed-aviary1.0)

Attachments

(2 files)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5b) Gecko/20030811 Mozilla Firebird/0.6.1+ Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5b) Gecko/20030811 Mozilla Firebird/0.6.1+ When you first bring up the page in a tab, the title show correctly in the tab title and the window title. However, if you change the focus to another tab and then bring the focus back to the first tab, the window title says [object HTMLImageElement], but the tab title is correct. If you refresh the tab, it display correctly in both the tab and window title. Reproducible: Always Steps to Reproduce: 1. Open 2 tabs 2. Goto http://phpbt.sourceforge.net/demo/ in the first tab 3. Switch to the second tab 4. Switch back to the first tab Actual Results: Window title says [object HTMLImageElement] Expected Results: Window title should say the title of the page, namely "phpBugTracker - Home"
*** This bug has been marked as a duplicate of 214832 ***
Status: UNCONFIRMED → RESOLVED
Closed: 21 years ago
Resolution: --- → DUPLICATE
Summary: Firebird shows [object HTMLImageElement] as page title in window title → window title shows [object HTMLImageElement] on page with <img name="title">
This is left unfixed from Bug 214832. Reopening.
Status: RESOLVED → UNCONFIRMED
Resolution: DUPLICATE → ---
Note that this is firebird-only -- I'm not seeing the problem in SeaMonkey. In fact, for SeaMonkey, http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/bindings/browser.xml#240 does the right thing. For firebird, http://lxr.mozilla.org/mozilla/source/toolkit/content/widgets/tabbrowser.xml#359 is buggy because it uses contentDocument.title instead of doing this the right way.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Blocks: 225791
Target Milestone: --- → Firebird1.0
Priority: -- → P3
Target Milestone: Firefox1.0 → Firefox1.0beta
Attached file A simpler test case
This should make sense; it's because there's an image with the "name" attribute set to "title". Seems like a bug to me, it shouldn't get the title from anywhere except the title element, no? But at least the cause is clear now - right? -[Unknown]
This problem is still an issue in 1.0PR. The links referenced above are now, I belive: http://lxr.mozilla.org/mozilla/source/toolkit/content/widgets/tabbrowser.xml#387 http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/bindings/browser.xml#252 Unless I'm mistaken, the code that gets the tab title (which works) is here: http://lxr.mozilla.org/mozilla/source/toolkit/content/widgets/tabbrowser.xml#685 I wonder if it could be changed such that the window title is set by the same function? (there's probably reason for why it doesn't do this, but I tried.) I'm going to request blocking-aviary1.0 on this - while it's not a big deal, I did run into it again last night (to my recollection, on spreadfirefox.com no less! But I might be remembering wrong, and can't find it now..) and it seems like a decent polish bug... at least maybe someone will look at it. And I can't imagine any localization impact.... Thanks, -[Unknown]
Flags: blocking-aviary1.0?
This may not be related, but I'm looking at an HTML document whose <TITLE> attribute has &ldquo; and &rdquo; in it (that's left-double-quote and right-double-quote entities, in case Bugzilla zaps the entities). The tab shows the title correctly, but the window title only shows up to the first entity.
(In reply to comment #6) > This may not be related, but I'm looking at an HTML document whose <TITLE> > attribute has &ldquo; and &rdquo; in it (that's left-double-quote and > right-double-quote entities, in case Bugzilla zaps the entities). The tab shows > the title correctly, but the window title only shows up to the first entity. While that is a different bug, it would be resolved by the same suggestion (assuming there is not a reason for it, such as platform rules on window title characters) of using the same code to get the window's title as the tab's. However, you may wish to look for a bug about that more specifically, or start a new bug. It is a different issue in its own right. -[Unknown]
over to ben
Assignee: firefox → bugs
Flags: blocking-aviary1.0? → blocking-aviary1.0+
Attached patch patchSplinter Review
bring over 'contentTitle' attr from xpfe tabbrowser and use that rather than using contentDocument.title directly.
br & trunk fixed.
Status: NEW → RESOLVED
Closed: 21 years ago20 years ago
Resolution: --- → FIXED
looks like it has been fixed on the branch, so could somebody please add the fixed-aviary1.0 keyword?
Keywords: fixed-aviary1.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: