Closed Bug 215962 Opened 16 years ago Closed 16 years ago

Time Tracking: field => "field" not wrapped in {}, causing bad params to ThrowUserError in process_bug.cgi

Categories

(Bugzilla :: Creating/Changing Bugs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: erik, Assigned: erik)

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3) Gecko/20030312
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3) Gecko/20030312

Line 187 of process_bug.cgi contains "field => $field" which should be wrapped
in {}, i.e. "{field => $field}". As it stands, ThrowUserError gets the wrong params.

Reproducible: Always

Steps to Reproduce:
1. Edit a bug with time constraints
2. Specify a zero / negative number (I used zero)
3. See weird error

Actual Results:  
Saw error

Expected Results:  
Displayed proper error
Attached patch Patch to fix bugSplinter Review
Just a quick patch to make life easier. Granted, we're talking all of two
characters here.
doh.
Assignee: myk → erik
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: --- → Bugzilla 2.18
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.189; previous revision: 1.188
done
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: approval+
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.