Closed
Bug 215962
Opened 21 years ago
Closed 21 years ago
Time Tracking: field => "field" not wrapped in {}, causing bad params to ThrowUserError in process_bug.cgi
Categories
(Bugzilla :: Creating/Changing Bugs, defect)
Bugzilla
Creating/Changing Bugs
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: erik, Assigned: erik)
Details
Attachments
(1 file)
427 bytes,
patch
|
justdave
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3) Gecko/20030312 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3) Gecko/20030312 Line 187 of process_bug.cgi contains "field => $field" which should be wrapped in {}, i.e. "{field => $field}". As it stands, ThrowUserError gets the wrong params. Reproducible: Always Steps to Reproduce: 1. Edit a bug with time constraints 2. Specify a zero / negative number (I used zero) 3. See weird error Actual Results: Saw error Expected Results: Displayed proper error
Assignee | ||
Comment 1•21 years ago
|
||
Just a quick patch to make life easier. Granted, we're talking all of two characters here.
Comment 2•21 years ago
|
||
doh.
Assignee: myk → erik
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: --- → Bugzilla 2.18
Updated•21 years ago
|
Attachment #129674 -
Flags: review+
Comment 3•21 years ago
|
||
Checking in process_bug.cgi; /cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v <-- process_bug.cgi new revision: 1.189; previous revision: 1.188 done
Status: NEW → RESOLVED
Closed: 21 years ago
Flags: approval+
Resolution: --- → FIXED
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•