215991 - editable contents of js prompt sheet may line wrap with no visual indication given

Status: RESOLVED FIXED

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[Chris Casciano]

Camino 2003080402 & many previous builds.

(bug became known to me while using the 'shorten bug query' bookmarklet here:
http://www.squarefree.com/bookmarklets/mozilla.html )

Long strings or long passages can be entered into a javascript prompt and when
this happens instead of staing on one line and folowing off the screen
horizontally like most UI elements (url bar, text fields, etc) this sheet seems
to want to word wrap.

In the case of a pre-populated dialog like the included where the user doesn't
know what the "default" content this may cause a number of problems may occur
including data loss or just erroneous data being submitted to an application.


Apparent content of prompt:

http://bugzilla.mozilla.org/

Actual content of prompt:
http://bugzilla.mozilla.org/buglist.cgi?product=Firebird&keywords=regression&votes=1&resolution=---&order=bugs.votes,
bugs.bug_id

To access the entire content care must be given to select all and copy paste
elsewhere or know to hit the down arrow to see the other 3 'lines' of text.

Resolution:
Either keep the content all on on one line as other elements and other browsrs
do (providing the visual clue of having overrunning text) or make the prompt
area a multi-line <html:textarea> like widget with scrollers and other visual
clues that there is more data.

Quick screen shot will be attached in a second.

Comment 1

[Chris Casciano]

Attachment: prompt that appears to have little content

heres a quick shot of the prompt used in this example... it looks almost
identical to the output of: javascript:prompt("Copy this:",
"http://bugzilla.mozilla.org/");

Comment 2

[Mike Pinkerton (not reading bugmail)]

curious, i'll take a look

Comment 3

[Wevah (Nate Weaver)]

I'm thinking the text field just needs to be changed from "wraps" to "scrolls".

Comment 4

[Samuel Sidler (old account; do not CC)]

Wevah: Care to test that and possibly submit a patch?

Comment 5

[Wevah (Nate Weaver)]

Attachment: Probable patch!

This should do it, if I got the file right. Someone should test this to make
sure.

Comment 6

[Wevah (Nate Weaver)]

Attachment: Real probable patch!

Oops, wrong method. Should use setScrollable:YES and not setWraps:NO.

Sorry for the quasi-spam.

Comment 7

[Mike Pinkerton (not reading bugmail)]

landed, thanks!