216023 - (function with inner function)-to-string conversion is broken

Status: VERIFIED WORKSFORME

(Core :: JavaScript Engine, defect)

Description

[Jesse Ruderman]

Steps to reproduce:
1. Load testcase.

Result:
1. NS_ERROR_XPC_BAD_CONVERT_JS
2. Empty function

Expected:
1. Non-empty function
2. Non-empty function

This breaks the "edit styles" bookmarklet, which writes two functions (init and
update) to a new window while creating the window.

works in firebird 07/29
works in firebird 07/30 (aebrehim's build)
broken in firebird 08/07
broken in firebird 08/09
broken in seamonkey 08/12

Comment 1

[Jesse Ruderman]

Attachment: testcase

Comment 2

[Gilles Durys]

I made some test with some of my old Firebird builds:
2003080521 works
2003080621 and later fails

Comment 3

[Phil Schwartau]

> 2003080521 works
> 2003080621 and later fails

Could this bug be a side effect of the 2003-08-05 checkin for bug 214761?
Seems like it, but there have been recent updates to the same code:
see bug 215878, for example, fixed late last night.

Reassigning to Brendan just in case. I will try today's build to see
what happens. I do see the bug in my build 2003-08-06-04 on WinNT.

Comment 4

[Phil Schwartau]

Today's Windows build just became available:
Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.5b) Gecko/20030813

The testcase works fine with this build, so I do think that
last night's checkin for bug 215878 may have fixed this.

Jesse: thank you for catching this. Does this also appear fixed
to you with today's build?

Comment 5

[Brendan Eich [:brendan]]

This should be all fixed now.  Is it better to mark WFM with a dependency on bug
215878, or just dup against 215878?  (In a release build, assertions are off and
the decompiler has sanity-checking code to avoid crashes, usually.  So while bug
215878 is a crash bug in debug builds, it can have symptoms such as this bug's
in release builds.)

I picked the WFM/dependency route -- feel free to change if I chose badly.

/be

Comment 6

[Jesse Ruderman]

The testcase and the "edit styles" bookmarklet work in Firebird 08/13.  Yay!