216034 - Brocade FibreChannel Switch gives JavaScript error: "newWin has no properties"

Status: RESOLVED INVALID

(Core :: DOM: Core & HTML, enhancement)

Description

[Ulrich Windl]

User-Agent:       Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.0.1) Gecko/20020903
Build Identifier: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.4) Gecko/20030624

When connecting to the webserver embedded in a Brocade FibreChannel Switch (a
Silkworm 3200 distributed by HP, Fabric OS v3.0.2f), some windows remain empty.
Examining the details, it turn out that some JavaScript triggers an error. The
code is like this:

newWin=window.open(...);
newWin.localtion.href = url;

The device URL is
http://switch_name/openwin.html?openurl=switch_ip/SwitchManager.html,wintitle=some_text,width=665,
height=230

Reproducible: Always

Steps to Reproduce:
Connect to a Brocade Silkwork 3200.
Click on the switch icon displayed on the start screen.
Actual Results:  
An empty window pops up.

Expected Results:  
A window with visible content should pop up.

The problem may be a JavaScript programming error on the server side. Maybe a
future version of mozilla could have some visible clue that a page had a
JavaScript error, or maybe just open the JavaScript Console for the first error.

Comment 1

[Phil Schwartau]

Reassigning to Networking. This reminds me very much of bug 192476,
"Linksys router ignores <script>"

For reference, here is the total list of bugs mentioning
"Linksys" in the Summary:

http://bugzilla.mozilla.org/buglist.cgi?bugidtype=include&order=bugs.bug_id&bug_id=134334,190524,192476,196740

Comment 2

[Darin Fisher]

Ulrich: can you please capture a Mozilla HTTP log using the steps given here:

  http://www.mozilla.org/projects/netlib/http/http-debugging.html

thanks!!

Comment 3

[Ulrich Windl]

*** Bug 216130 has been marked as a duplicate of this bug. ***

Comment 4

[Ulrich Windl]

Attachment: Requested browser trace file

This is a session trace when accessing the failing page.

Comment 5

[Ulrich Windl]

Attachment: Here is the page source that causes the failure

As I'm not sure whether the HTML source is buggy, or Mozilla is, I'm sending
the source of the page that doesn't display.

Comment 6

[Phil Schwartau]

In the HTML file attached above, here is the only mention of |newWin|:

function openwin(url, title)
{
  newWin=window.open("",title,
                     "toolbar=no,scrollbars=yes,resizable=no,menubar=no,
                      width="+defWidth+",height="+defHeight);
  newWin.location.href = url;

  // Bug-000879: JavaScript error when clicking Switch Adminmore than once
  if (!newWin.opener)
    newWin.opener = self;
  //newWin.opener.name = "opener";

  // Bring the window to the top of the window stack and give focus
  //5851 does not really do anything but causes error in IE4.0 so just
  //comment out the call to focus()
  //newWin.focus();
}


Just as Ulrich originally reported above, the key lines are

              newWin=window.open(...);
              newWin.location.href = url;

From this, it's hard to see why we would get an error in the 
JavaScript Console such as "newWin has no properties". 

Ulrich:

1. Could you paste here the exact error you are seeing in the 
   JavaScript Console, including the file and line number? 

2. Do you know if IE6 works without error on this?

Thanks -

Comment 7

[Ulrich Windl]

First, I even think that the code worked without problem in Mozilla 1.2.1 (but
with JRE 1.3.1_02). I upgraded both, Mozilla and JRE (to 1.4.2). I don't have MS
IE 6.0, but I have MS IE 5.5: It works with IE 5.50.4807.2300IC.
For the exact error message, see attachment.
I have a suspect: Should "newWin" be declared as variable before being used?

Comment 8

[Ulrich Windl]

Attachment: Error message copied from JavaScript Console (EOL added)

This is the requested error messgae that appears. BTW, it's the only error
message that appears so far.

Comment 9

[Darin Fisher]

there is nothing in the HTTP log file indicating any networking problems.  could
this be somehow related to popup blocking?

this doesn't look like a networking bug to me... reassigning to "DOM Other"
though that likely isn't right either...

Comment 10

[Phil Schwartau]

Ulrich: could you try creating a new Mozilla profile? If the Profile Manager
doesn't come up automatically, you can force it from a command prompt:

                [ ]./mozilla -profilemanager

Do you still see the bug if you run Mozilla under a new profile?

Comment 11

[Ulrich Windl]

Problem work-around has been found: Blocking unrequested popup-windows was the
culprit (thanks to [e-mail]). However the current implementation is not
very good: The user has no way to know that some popup window has been blocked.
(Play a sound is not an option here). Maybe in addition to the JavaScript
console, there should be a general "BrowserConsole" where invalid HTML and
denied popup windows should be logged.
Just an idea...

Comment 12

[Darin Fisher]

marking INVALID... there should be a small icon in the browser status bar that
appears when a popup has been blocked.  clicking it gives you the ability to
unblock popups for that specific site.