216572 - 002goodperl.t adds an extra test for every additional Throw*Error violation in the same file

Status: RESOLVED FIXED

(Bugzilla :: Testing Suite, defect)

Description

[Dave Miller [:justdave]]

# Looks like you planned 240 tests but ran 8 extra.
dubious
        Test returned status 19 (wstat 4864, 0x1300)
DIED. FAILED tests 199-206, 220-222
        Failed 11/240 tests, 95.42% okay

example:
#     Failed test (t/002goodperl.t at line 113)
not ok 199 - post_bug.cgi has a Throw*Error call on line 181 
#                       which doesn't use a tag --ERROR
#     Failed test (t/002goodperl.t at line 113)
not ok 200 - post_bug.cgi has a Throw*Error call on line 612 
#                       which doesn't use a tag --ERROR
#     Failed test (t/002goodperl.t at line 113)
not ok 201 - post_bug.cgi has a Throw*Error call on line 619 
#                       which doesn't use a tag --ERROR
#     Failed test (t/002goodperl.t at line 113)
not ok 202 - process_bug.cgi has a Throw*Error call on line 1230 
#                       which doesn't use a tag --ERROR
#     Failed test (t/002goodperl.t at line 113)
not ok 203 - process_bug.cgi has a Throw*Error call on line 1243 
#                       which doesn't use a tag --ERROR
#     Failed test (t/002goodperl.t at line 113)
not ok 204 - process_bug.cgi has a Throw*Error call on line 1253 
#                       which doesn't use a tag --ERROR
#     Failed test (t/002goodperl.t at line 113)
not ok 205 - process_bug.cgi has a Throw*Error call on line 1257 
#                       which doesn't use a tag --ERROR
#     Failed test (t/002goodperl.t at line 113)
not ok 206 - process_bug.cgi has a Throw*Error call on line 1598 
#                       which doesn't use a tag --ERROR

Note this is running the test on Zippy's code, not mainstream Bugzilla, so these
aren't errors we need to fix, just the test is broken because it reports a new
test number for each error instead of collecting all the errors from the same
file and reporting them as one test.

Comment 1

[Zach Lipton [:zach]]

Attachment: Patch v1

We really should use File::Find and do this right, but this should fix it until
we go even deeper in the directory structure (at which point we've gone insane
;)

Comment 2

[Zach Lipton [:zach]]

Comment on attachment 130005 [details] [diff] [review]
Patch v1

Gaah, attached this to the wrong bug :)

Comment 3

[Marc Schumann [:Wurblzap]]

Attachment: Patch

One-liner.

Comment 4

[Christian Reis]

Comment on attachment 157136 [details] [diff] [review]
Patch

Doh :-)

Comment 5

[Vlad Dascalu]

Checking in t/002goodperl.t;
/cvsroot/mozilla/webtools/bugzilla/t/002goodperl.t,v  <--  002goodperl.t
new revision: 1.14; previous revision: 1.13
done
Checking in t/002goodperl.t;
/cvsroot/mozilla/webtools/bugzilla/t/002goodperl.t,v  <--  002goodperl.t
new revision: 1.13.2.1; previous revision: 1.13
done