216751 - general.config.filename set in user's prefs.js overrides setting in all.js

Status: RESOLVED FIXED

(Core :: Preferences: Backend, defect)

Description

[Josef Siemes]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.2.1) Gecko/20021130
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; de-AT; rv: 1.4) Gecko/20030625

If I set general.config.filename in all.js, and also set general.config.filename
in prefs.js, mozilla tries to load the config file defined in prefs.js.

Reproducible: Always

Steps to Reproduce:
1. create mozilla.cfg in $MOZILLA_HOME
2. edit $MOZILLA_HOME/default/prefs/all.js, add
pref("general.config.filename", "mozilla.cfg");
3. edit $HOME/.mozilla/[..]/prefs.js, add:
user_pref("general.config.filename", "ttt.cfg");

Actual Results:  
Mozilla doesn't start, complains about not being able to read the config file.
strace shows that mozilla tries to open $MOZILLA_HOME/ttt.cfg, instead of
$MOZILLA_HOME/mozilla.cfg.

Expected Results:  
Mozilla should have picked the $MOZILLA_HOME/mozilla.cfg file.

Since this allows the user to override the config file, the user may be able
to create an own configuration instead of the locked down default configuration.

Comment 1

[Frank Wein [:mcsmurf]]

Confirming with current SeaMonkey trunk build, this probably also affects FF and TB.

Comment 2

[Frank Wein [:mcsmurf]]

Attachment: Patch

Comment 3

[Asa Dotzler [:asa]]

David, can you review this patch for us? 

Comment 4

[Frank Wein [:mcsmurf]]

Patch has been checked in, probably 2nd patch will follow which will fix another
part of code (not required i think, but nice-to-have).

Comment 5

[David :Bienvenu]

this breaks MCD, as near as I can tell...will attach a fix for that in a few minutes.

Comment 6

[David :Bienvenu]

Attachment: fix MCD

the mcd.cfg file sets prefs on the main branch, not the default branch, so we need to be checking the auto-admin prefs from the main branch.

Comment 7

[David :Bienvenu]

fix landed for 2.0 - will land on the trunk when the tree is a bit greener.