Last Comment Bug 216751 - general.config.filename set in user's prefs.js overrides setting in all.js
: general.config.filename set in user's prefs.js overrides setting in all.js
: fixed1.8.1.2
Product: Core
Classification: Components
Component: Preferences: Backend (show other bugs)
: Trunk
: x86 All
-- major (vote)
: ---
Assigned To: David :Bienvenu
: sairuh (rarely reading bugmail)
: Benjamin Smedberg [:bsmedberg]
Depends on:
  Show dependency treegraph
Reported: 2003-08-20 02:38 PDT by Josef Siemes
Modified: 2007-01-30 21:17 PST (History)
4 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch (686 bytes, patch)
2005-07-12 13:29 PDT, Frank Wein [:mcsmurf]
mozilla: review+
brendan: superreview+
asa: approval1.8b4+
Details | Diff | Splinter Review
fix MCD (2.75 KB, patch)
2007-01-30 14:06 PST, David :Bienvenu
mscott: superreview+
Details | Diff | Splinter Review

Description User image Josef Siemes 2003-08-20 02:38:54 PDT
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.2.1) Gecko/20021130
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; de-AT; rv: 1.4) Gecko/20030625

If I set general.config.filename in all.js, and also set general.config.filename
in prefs.js, mozilla tries to load the config file defined in prefs.js.

Reproducible: Always

Steps to Reproduce:
1. create mozilla.cfg in $MOZILLA_HOME
2. edit $MOZILLA_HOME/default/prefs/all.js, add
pref("general.config.filename", "mozilla.cfg");
3. edit $HOME/.mozilla/[..]/prefs.js, add:
user_pref("general.config.filename", "ttt.cfg");

Actual Results:  
Mozilla doesn't start, complains about not being able to read the config file.
strace shows that mozilla tries to open $MOZILLA_HOME/ttt.cfg, instead of

Expected Results:  
Mozilla should have picked the $MOZILLA_HOME/mozilla.cfg file.

Since this allows the user to override the config file, the user may be able
to create an own configuration instead of the locked down default configuration.
Comment 1 User image Frank Wein [:mcsmurf] 2005-07-12 04:37:23 PDT
Confirming with current SeaMonkey trunk build, this probably also affects FF and TB.
Comment 2 User image Frank Wein [:mcsmurf] 2005-07-12 13:29:25 PDT
Created attachment 189091 [details] [diff] [review]
Comment 3 User image Asa Dotzler [:asa] 2005-07-12 14:10:37 PDT
David, can you review this patch for us? 
Comment 4 User image Frank Wein [:mcsmurf] 2005-07-13 22:02:51 PDT
Patch has been checked in, probably 2nd patch will follow which will fix another
part of code (not required i think, but nice-to-have).
Comment 5 User image David :Bienvenu 2007-01-30 13:56:09 PST
this breaks MCD, as near as I can tell...will attach a fix for that in a few minutes.
Comment 6 User image David :Bienvenu 2007-01-30 14:06:56 PST
Created attachment 253396 [details] [diff] [review]
fix MCD

the mcd.cfg file sets prefs on the main branch, not the default branch, so we need to be checking the auto-admin prefs from the main branch.
Comment 7 User image David :Bienvenu 2007-01-30 17:01:25 PST
fix landed for 2.0 - will land on the trunk when the tree is a bit greener.

Note You need to log in before you can comment on or make changes to this bug.