Closed
Bug 216821
Opened 21 years ago
Closed 12 years ago
cleanup nsLocalFileWin.cpp
Categories
(Core :: XPCOM, enhancement)
Tracking
()
RESOLVED
INCOMPLETE
People
(Reporter: darin.moz, Unassigned)
Details
Attachments
(1 obsolete file)
there's a lot of little things that should be cleaned up in nsLocalFileWin.cpp.
first of all, IsShortcut() is broken in several ways. there are other things
i'd like to fix / cleanup. this may turn into a bug about expanding the
documentation in nsIFile/nsILocalFile.idl as well :)
|
Reporter | |
Updated•21 years ago
|
Severity: normal → minor
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.6alpha
|
|
Reporter | |
Updated•21 years ago
|
Severity: minor → enhancement
Target Milestone: mozilla1.6alpha → Future
|
|
Reporter | |
Updated•19 years ago
|
Assignee: darin → nobody
Status: ASSIGNED → NEW
QA Contact: scc → xpcom
Target Milestone: Future → ---
|
||
Comment 1•17 years ago
|
||
This patch cleans up nsLocalFile::Create to propagate any errors from OpenFile up the stack rather than incorrectly returning NS_ERROR_FILE_EXISTS. It also teaches ConvertWinError to map ERROR_INVALID_NAME to NS_ERROR_ILLEGAL_VALUE.
Attachment #283084 -
Flags: review?(benjamin)
|
||
Comment 2•17 years ago
|
||
Comment on attachment 283084 [details] [diff] [review]
OpenFile and Create API cleanups
I can't review this without unit tests.
Attachment #283084 -
Flags: review?(benjamin) → review-
|
|
||
Comment 3•17 years ago
|
||
Comment on attachment 283084 [details] [diff] [review]
OpenFile and Create API cleanups
We're gonna need this change as part of the fix for bug 393488; I've put a newer version of this with a test case in that bug. Once I've got something ready to checkin, I'll get it reviewed there.
Attachment #283084 -
Attachment is obsolete: true
|
|
||
Comment 4•12 years ago
|
||
Many things have changed, so I don't think this bug is useful any more.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → INCOMPLETE
You need to log in
before you can comment on or make changes to this bug.
Description
•