Closed Bug 217219 Opened 21 years ago Closed 21 years ago

Messages in votes errors are incorrectly CHOMP'd

Categories

(Bugzilla :: User Interface, defect)

2.17.4
defect
Not set
trivial

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: timeless, Assigned: timeless)

References

Details

Attachments

(1 file, 2 obsolete files)

 
Attached patch avoid POST_CHOMP (obsolete) — Splinter Review
Comment on attachment 130363 [details] [diff] [review]
avoid POST_CHOMP

i find numbers at the end of sentences to be a bit awkward.

should i add ' votes' to the tail of the sentences?
Attachment #130363 - Flags: review?(justdave)
Yes, adding a " votes" wouldn't hurt.

Gerv
Comment on attachment 130363 [details] [diff] [review]
avoid POST_CHOMP

r= justdave if you fix your nits from comment 2
Attachment #130363 - Flags: review?(justdave) → review+
Severity: normal → trivial
OS: Windows 2000 → All
Hardware: PC → All
Target Milestone: --- → Bugzilla 2.18
Comment on attachment 130363 [details] [diff] [review]
avoid POST_CHOMP

nevermind, it's way bitrotted. :)
Attachment #130363 - Flags: review+ → review-
and there's now two instances of this issue to fix in the same error message.
Attachment #130363 - Attachment is obsolete: true
Attachment #131459 - Flags: review?(justdave)
Comment on attachment 131459 [details] [diff] [review]
that's the problem with waiting for approval

> should i add ' votes' to 
> the tail of the sentences?

Well?
Attachment #131459 - Flags: review?(justdave) → review-
Comment on attachment 131459 [details] [diff] [review]
that's the problem with waiting for approval

And shouldn't you be using [%+ there instead of line break hacks?

(It would be really nice if the bug summary actually explained what the bug in
this case is :-P)
Attached patch new textSplinter Review
Attachment #131459 - Attachment is obsolete: true
Attachment #134256 - Flags: review+
Status: NEW → ASSIGNED
Flags: approval?
Summary: Votes errors are POST_CHOMP'd → Messages in votes errors are incorrectly CHOMP'd
Flags: approval? → approval+
checked in
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Blocks: 359768
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: