217376 - Link tools with -R on Solaris

Status: RESOLVED DUPLICATE of bug 245518

(NSS :: Tools, defect)

Description

[Kirk Erickson]

We now generate packages for Solaris and RPMs for Linux, installing
the tools in /usr/lib/mps/bin.  As things stand user's must set
LD_LIBRARY_PATH on Solaris for the commands to find the shared libs in /usr/lib/mps.

Adding -R '<RPATH>' in linking the tools would simplify their use
by providing the runtime linker with a likely path to the shared libs.
 
A Sun bug (4770039) was filed by the DS team, requesting:

   -R $ORIGIN/../lib

I'm proposing a simple one line change to cmd/platlibs.mk for
Solaris specifically, which looks upstairs first:

   EXTRA_SHARED_LIBS += -R '$(ORIGIN)/..' -R '$(ORIGIN)/../lib'

This will make installed Solaris packages work, since the libs
install in /usr/lib/mps, and the tools into /usr/lib/mps/bin
I tested this on the SUN_SECURITY_3_3_BRANCH.  

Without the change:

ldd modutil
        libplc4.so =>    (file not found)
        ...
and with the new linker argument, after installation:

# ldd modutil
	libplc4.so =>	 ../libplc4.so

ke119340@kentuckyderby[126] elfdump -d certutil

Dynamic Section:  .dynamic
     index  tag               value
       [0]  NEEDED           0x837b            libplc4.so
       [1]  NEEDED           0x8386            libplds4.so
...
      [11]  RUNPATH          0x83e8            /..:/../lib
      [12]  RPATH            0x83e8            /..:/../lib

Without the change, the path is absolute and is only useful
on the build machine where the tools were linked.  So there's
no apparent downside.

Comment 1

[Kirk Erickson]

Attachment: patch for SUN_SECURITY_3_3_BRANCH

Comment 2

[Kirk Erickson]

Comment on attachment 130434 [details] [diff] [review]
patch for SUN_SECURITY_3_3_BRANCH

Wan-Teh, can you review?

Comment 3

[Kirk Erickson]

Attachment: patch for SUN_SECURITY_3_3_BRANCH

Checked this in, after discussion and approval from
Wan-Teh.  It reverses the order of the -R arguments, 
so first../lib is searched and then ,,/.  
Also changed $(ORIGIN) to $$ORIGIN.

I will come up with an analogous change for the TIP,
after we see Sonja's 3.3.6 build through some testing.

Comment 4

[Kirk Erickson]

Attachment: patch for SUN_SECURITY_3_3_BRANCH

Sorry.	This was the patch I checked in a few minutes ago.

Comment 5

[Kirk Erickson]

Attachment: patch for SUN_SECURITY_3_3_BRANCH

Sorry again.  This is what checked into SUN_SECURITY_3_3_BRANCH.

Comment 6

[Julien Pierre]

Mass reassign of Kirk's bugs.

Comment 7

[Wan-Teh Chang]

Marked this bug as a duplicate, even though this bug
was created first.

*** This bug has been marked as a duplicate of 245518 ***