217690 - not prompted to save password if the page combines login and registration forms (e.g. on some wiki sites)

Status: RESOLVED WORKSFORME

(Toolkit :: Password Manager, defect)

Description

[Jeremy M. Dolan]

Entering my username and password at Wikipedia doesn't present me with a prompt
to save them. There are no autocomplete=off type flags on the form.

The password manager is somehow confused by the page which also doubles for new
user registration.

Actual Results: I have to keep a seperate password file for this site, and
repeatedly manually log in.

Expected Behavior: Mozilla will centrally manage this login for me as it does
all of my others.

Comment 1

[Nitin (vfwlkr)]

Changing module to 'password manager'.

Also reproducible at mozillazine knowledge base
http://kb.mozillazine.org/index.phtml?title=Special:Userlogin&returnto=Knowledge_Base

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040206 Firefox/0.8

Comment 2

[Amit Paspunattu]

can be replicated on winxp home edition using the build:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040206 Firefox/0.8

I believe the password manager doesn't handle the forms if the number of input
fields are more than two in the form.
It doesn't work for 
a. www.americanexpress.com
b. www.mail.yahoo.com
these sites have more than two input fields for the username and password.

but works fine for
www.rediff.com which has only username and password.

Comment 3

[Nitin (vfwlkr)]

Amit,

mail.yahoo.com and americanexpress.com prevent the browser from storing
username/password. This bug is for wikipedia

If you want to store passwords for sites that tell the browser otherwise, you
might find this useful: 
http://www.squarefree.com/bookmarklets/forms.html#remember_password

Comment 4

[Eric Portelance]

I'm seeing the same problem on http://www.ymdb.com.  Not only that, but if you
set it to automatically log you in, Firefox seems to delete the cookies when the
browser is closed, and you have to login again each time you open the browser.

Comment 5

[Flammie Pirinen]

I don't know if there has been attempts to fix this bug, but at least my firefox
has saved the password information since perhaps some 0.8 version. The problem I
came here reporting about was that on that page firefox thinks it has to change
the password every time I log in. (It might be that the initial saving of the
password came from the my registration, which changes the thing compared to
situation in comment 0 ).

And what's even more odd is that when I allow it to save "changes" to the
password, it adds two entries in the saved passwords list. The other one's for
my user name and password, and then there's other entry called '<>'.  

Should I make a separate bug for this or is it related?

Comment 6

[Travis Hume]

I'm seeing the same behaviour on the eclipse.org website.  Firefox/0.9.1+
refuses to save the password for the newsgroups:
http://www.eclipse.org/newsportal/thread.php?group=eclipse.tools.jdt and mailing
lists: http://dev.eclipse.org/mhonarc/lists/platform-releng-dev/maillist.html

This is a regression from .8

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

Not a "blocker"

Comment 8

[Matt Thompson]

I believe I'm being hit by this as well.  My sites are sumogames.com sites, e.g.:

http://isp.sumogames.com/

Quite annoying, but keeps the U/P skills up.

Comment 9

[Joona Palaste]

This is happening to me too. Quite annoying.

Comment 10

[Lapo Luchini]

Problem is, WikiMedia pages are not distinguishable from an actual "change your
pwd" form... I think it would be best to open a bug on WikiMedia
bugzilla-or-the-like to ask them to separate registration and login in different
pages.
BTW: I don't think this "bug" is Linux-specific, but I can't change that

Comment 11

[Uri Bernstein]

All/All; won't make it to Firefox 1.0; severity normal.

Comment 12

[Dave Townsend [:mossop]]

A couple of potential ways that might solve this:

First you could look at the password fields and if only one is non-empty then
you could take that to be the password. If that is not correct then the data
stored will be fine, when you go to the page it will fill the username and
password in, leaving the other password fields blank just as they were anyway.

Alternativly maybe only count passwords that dont have autocomplete=off on them,
then the wiki and wherever else crops up have the oppurtunity to tell firefox
which password they want you to save.

Comment 13

[Matt]

Another possible attempt would be asking if the user wants to remember the
password if only one password field is filled out.  To change or make a
password, there's always two password fields that are filled out, but when
logging in, there's only one.

Comment 14

[Phillip Stewart :P]

A workaround is to use MODIv2 (google it) to remove the second password input
before submitting.

Comment 15

[Matt]

Would it be worth mentioning that Wikipedia doesn't use that odd login system anymore?  It works on Wikipedia now, so maybe this bug's title should be changed.

Comment 16

[Nickolay_Ponomarev]

>Would it be worth mentioning that Wikipedia doesn't use that odd login system
>anymore
Yes, but there are other wiki sites (e.g. our very own developer.mozilla.org) that suffer from this bug.

Comment 17

[kself]

ObMeToo:  moin moin sites (though not the current public http://moinmoin.wikiwikiweb.de/MoinMoinWiki?action=login) also exhibit this.

It might be useful to simply allow direct entry of site/auth data into the Firefox Preferences Passwords dialog.  Currently that's read-only.

Comment 18

[Justin Dolske [:Dolske]]

This now worksforme on trunk, although most of the testcases here are no longer valid.

Bug 374723 rewrote the password mananger in JS, and as part of that the processing of form submission was redesigned to handle this case.