218825 - Remove nsIFolder.idl (and nsMsgFolder.*)

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[[e-mail]]

IMHO nsIFolder serves no useful purpose, it just takes up time and space.

Steps to remove nsIFolder:
1. Integrate nsMsgFolder into nsMsgDBFolder (nice, but not essential)
2. Convert all users of nsIFolder to nsIMsgFolder
3. Move nsIFolder definitions into nsIMsgFolder (+ nsMsgFolder.h if not 1.)
4. Remove nsIFolder from the build

Additionally we could review some other interfaces e.g. nsIFolderListener could
use nsIMsgFolder on all of its item parameters.

Comment 1

[[e-mail]]

Attachment: Change all consumers of nsIFolder (except nsMsgFolder) to use nsIMsgFolder

Comment 2

[David :Bienvenu]

this looks good, r=bienvenu with some nits,

+  *aParentMsgFolder = parent;
+  NS_IF_ADDREF(*aParentMsgFolder);
the assignment can be inside the NS_IF_ADDREF (which is apparently templatized
for this very reason)

same here:
+  *aRootMsgFolder = m_rootFolder;
+  NS_IF_ADDREF(*aRootMsgFolder);

here, please use the prevelant braces style
+  if (path.Length() == 1) {
+    NS_ADDREF(*aFolder = rootFolder);
+    return NS_OK;
+  }

so 
if (path.Length() == 1)
{
}

Comment 3

[[e-mail]]

Attachment: Updated for review comments and bitrot

As well as those three fixes I also fixed a second use of ) {, plus I deleted
an unused nsIFolder (rather than renaming it to nsIMsgFolder).

Comment 4

[[e-mail]]

Comment on attachment 131728 [details] [diff] [review]
Updated for review comments and bitrot

Transferring requests.

Comment 5

[[e-mail]]

Comment on attachment 131728 [details] [diff] [review]
Updated for review comments and bitrot

Trying different reviewer.

Comment 6

[Henry Jia]

Comment on attachment 131728 [details] [diff] [review]
Updated for review comments and bitrot

sr=Henry

Comment 7

[[e-mail]]

Attachment: Change consumers of nsMsgFolder to use nsMsgDBFolder

Comment 8

[[e-mail]]

Attachment: "Diff" to aid review of the next patch

The next patch removes nsMsgFolder.cpp and moves all of its methods into
nsMsgDBFolder.cpp, except where they are already overridden. This bloats the
size of the patch, so what I have done here is to concatenate nsMsgDBFolder.cpp
and nsMsgFolder.cpp and rename the functions so you can see there isn't much
difference between the contatenation and the new nsMsgDBFolder.cpp

Comment 9

[[e-mail]]

Attachment: Supplement to attachment 135414

Don't know how I manged to leave these out :-[

Comment 10

[David :Bienvenu]

Comment on attachment 135496 [details] [diff] [review]
Supplement to attachment 135414 [details] [diff] [review]

r/sr=bienvenu

Comment 11

[[e-mail]]

Attachment: Delete nsMsgFolder.* and move to nsMsgDBFolder.*

In answer to my rhetorical question, probably the same way that I managed to
leave out the "a" between the "n" and "g" in "manged" ;-)

Comment 12

[[e-mail]]

Attachment: Delete nsIFolder.idl and move to nsMsgFolder.idl

As an alternative to reviewing the last two patches together, the previous
patch may be reviewed separately if the line NS_DECL_NSIFOLDER is temporarily
added between NS_DECL_NSIMSGFOLDER and NS_DECL_NSICOLLECTION.

Comment 13

[David :Bienvenu]

Comment on attachment 135499 [details] [diff] [review]
Delete nsMsgFolder.* and move to nsMsgDBFolder.*

there's lot of stuff that could be cleaned up (nit-type stuff in the existing
code) but it's all code that was simply moved. Let's just make sure this works
and then we can clean up other stuff later.

Comment 14

[[e-mail]]

Fix checked in.

Comment 15

[Daniel de Wildt]

I filled bug 227175 (leak in a collation).
Is it possible that kCollationKeyGenerator is not freed?