219080 - Support for GeneralizedTime in CRMF libraries

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Julien Pierre]

Currently, the CRMF library only supports UTCTime in the optional validity fields.
GeneralizedTime is also allowed.

The coding fixes are fairly straightforward (change to templates).

Most of the work to do is testing. We need to set up a CA and a CRMF client
(Mozilla) in the year 2050 and check that they work.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Julien,  are you willing to split this work with me?  
You code the fixes, and I test and debug them?

Comment 2

[Julien Pierre]

Attachment: encode / decode GeneralizedTime in CRMF

Sure !

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Thanks Julien.  Taking this bug to test.

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

Putting on my NSS 3.10 radar screen.

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 150315 [details] [diff] [review]
encode / decode GeneralizedTime in CRMF

Julien, This patch calls DER_TimeChoiceToTime, which doesn't seem to exist.
I did some grepping trying to find something with a similar name, and did not
find an obvious substitute.  so, r-  for this problem.

>Index: respcmn.c
>-    return DER_UTCTimeToTime(*dest, src);
>+    return DER_TimeChoiceToTime(*dest, src);

Comment 6

[Nelson Bolyard (seldom reads bugmail)]

Reassigning to Julien for another patch revision.

Comment 7

[Julien Pierre]

Sorry, Nelson. The function was supposed to be DER_DecodeTimeChoice .

Comment 8

[Nelson Bolyard (seldom reads bugmail)]

Attachment: patch v2

taking bug again.  
The previous patch encoded time into a temporary SECItem, and then
left it there, so it never got encoded into the cert request.
This patch replaces calls to the old function crmf_encode_utctime with 
calls to DER_EncodeTimeChoice.	This works.  
The crmftest program failed to discover the missing validity period,
so this patch adds a check for it.

Comment 9

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 153366 [details] [diff] [review]
patch v2

Julien, please review this patch.

Comment 10

[Julien Pierre]

Comment on attachment 153366 [details] [diff] [review]
patch v2

Looks good.

Comment 11

[Nelson Bolyard (seldom reads bugmail)]

nss/lib/crmf/crmfreq.c;      new revision: 1.4;  previous revision: 1.3
nss/lib/crmf/crmftmpl.c;     new revision: 1.6;  previous revision: 1.5
nss/lib/crmf/respcmn.c;      new revision: 1.10; previous revision: 1.9
nss/cmd/crmftest/testcrmf.c; new revision: 1.6;  previous revision: 1.5