VERIFIED FIXED

Status

www.mozilla.org
General
VERIFIED FIXED
15 years ago
6 years ago

People

(Reporter: dolphinling, Assigned: Cameron)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

15 years ago
http://www.mozilla.org/foundation/donate.html is missing several </a> tags and
also has several "document type does not allow element ... here" errors. 

Never done anything with dependencies, but this blocks bug 151557, right?
(Reporter)

Comment 1

15 years ago
Created attachment 131418 [details]
Quick fix to make it 4.01 transitional

This fixes it... I added </a>'s on lines 120, 186, 210, and 240, changed <div>
and </div> to <span> and </span> on lines 186, 210, and 240, and removed
border="0" on lines 205 and 230 (don't know if that last bit will cause any
problems with borders showing up on older browsers...). 

It should probably be noted that the page uses a meta tag for character set,
and I remember reading just a minute ago (somewhere on *.mozilla.org) about
that being bad.

Comment 2

15 years ago
fixed
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Summary: http://www.mozilla.org/foundation/donate.html doesn't validate → http://www.mozilla.org/foundation/donate.html doesn't validate
(Reporter)

Comment 3

15 years ago
No, it's not fixed. The w3c validator still complains about border="0" in two
places, line 189 and 230. 

(and I messed up in my comments last time, 205 should have been 189)

Comment 4

15 years ago
validator.w3.org says:
Line 189, column 57:  there is no attribute "BORDER"  (explain...).
...mage" src="x-click-but21.gif" border="0" name="submit" alt="Make a Donation"

-> reopening.

It's also rendered in quirks mode. The DTD should look like
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd">
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 6

15 years ago
According to http://mozilla.org/docs/web-developer/quirks/doctypes.html
"the public identifier "-//W3C//DTD HTML 4.01 Transitional//EN", without a
system identifier" triggers quirks mode.

"The public identifier "-//W3C//DTD HTML 4.01 Transitional//EN", with a system
identifier" triggers almost standards mode. So please switch to the doctype I
mentioned in comment 4.

Comment 7

15 years ago
David, you only fixed the error at line 189, but there's another border="0" at
line 211! Please also use a valid doctype, see comment 6.

Comment 8

15 years ago
should work now
and I'm daniel, not david

Comment 9

15 years ago
It's now valid HTML 4.01 transitional.
Thanks Daniel! Sorry 'bout the name confusion.
->fixed.
Status: REOPENED → RESOLVED
Last Resolved: 15 years ago15 years ago
Resolution: --- → FIXED
(Reporter)

Comment 10

15 years ago
After redesign, no longer validates. Reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 11

15 years ago
http://validator.w3.org/check?uri=http%3A%2F%2Fwww.mozilla.org%2Ffoundation%2Fdonate.html

re-fixed
Status: REOPENED → RESOLVED
Last Resolved: 15 years ago15 years ago
Resolution: --- → FIXED

Comment 12

14 years ago
This one still (or again) has an error.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 13

14 years ago
Created attachment 158117 [details] [diff] [review]
patch #1

This one fixes some of the indenting as well and removes the table. However,
the table should probably be replaced with a DIV which get the double border
effect, no?

Comment 14

14 years ago
Nicolas, for some reason I can't request a review on the patch. Could you take a
look at it? (I'm asking you since you offered helping out, if you don't have
that many time, just leave it.)

Comment 15

14 years ago
Checking in mozilla-org/html/foundation/donate.html;
/cvsroot/mozilla-org/html/foundation/donate.html,v  <--  donate.html
new revision: 1.25; previous revision: 1.24
done
Status: REOPENED → RESOLVED
Last Resolved: 15 years ago14 years ago
Resolution: --- → FIXED

Updated

14 years ago
No longer blocks: 151557

Updated

14 years ago
Status: RESOLVED → VERIFIED
QA Contact: imajes → daniel.bugmail
(Assignee)

Comment 16

12 years ago
Got some problems with ampersands. Patch shortly.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 17

12 years ago
Created attachment 233945 [details] [diff] [review]
encode ampersands correctly

Fixed to make validate
Assignee: endico → bugs.cameron
Attachment #131418 - Attachment is obsolete: true
Attachment #158117 - Attachment is obsolete: true
Status: REOPENED → ASSIGNED
Attachment #233945 - Flags: review?(reed)
QA Contact: danielwang → www-mozilla-org
Comment on attachment 233945 [details] [diff] [review]
encode ampersands correctly

r=reed

Thanks!
Attachment #233945 - Flags: review?(reed) → review+
Checking in mozilla-org/html/foundation/donate.html;
/cvsroot/mozilla-org/html/foundation/donate.html,v  <--  donate.html
new revision: 1.37; previous revision: 1.36
done

Please verify once it reaches stage/production.
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago12 years ago
Resolution: --- → FIXED
(Assignee)

Comment 20

12 years ago
VERIFIED
Status: RESOLVED → VERIFIED
Product: mozilla.org → Websites
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in before you can comment on or make changes to this bug.