219191 - "My Downloads", "The selected Actions..." are not localizable

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[u60234]

See line
http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/downloads/content/pref-downloads.js#61

Comment 1

[Mike Connor [:mconnor]]

-> me, 0.7

Comment 2

[Mike Connor [:mconnor]]

Attachment: localization patch

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 131772 [details] [diff] [review]
localization patch

I think this is a blocker for 0.7.  0.6 and 0.6.1 both shipped with
localization bugs, I'd like 0.7 to not share that

Comment 4

[Mike Connor [:mconnor]]

as a note, this fixes both this bug and bug 219192 (not worth writing two
patches for essentially the same bug).

Comment 5

[Steffen Wilberg]

Mike, there's some more in pref-downloads.js:
targetFolder.append("My Downloads"); // XXXben localize
http://lxr.mozilla.org/mozilla/source/browser/components/prefwindow/content/pref-downloads.js#205

dir.append("My Downloads"); // XXXben localize
http://lxr.mozilla.org/mozilla/source/browser/components/prefwindow/content/pref-downloads.js#300

// XXXben LOCALIZE!
var title = "Remove Actions";
var msg = "The selected Actions will no longer be performed when files of the
affected types are downloaded. Are you sure you want to remove these Actions?";
http://lxr.mozilla.org/mozilla/source/browser/components/prefwindow/content/pref-downloads.js#341

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: better patch

I adapted your patch - it wasn't quite "localizable" in the strict sense -
strings shouldn't be appended, substitution values should be used instead. I'm
going to check this into the trunk and the .7 br shortly.

Comment 7

[Mike Connor [:mconnor]]

Ben, thanks, I knew this patch wasn't quite right, haven't had time to come back
to it in the last few days.  Your patch (and mine) doesn't address the strings
mentioned in comment 5 though, which includes the confirmation dialog when
removing a file type.

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

Fixed, branch and trunk, 0.7

Comment 9

[Steffen Wilberg]

Thanks for fixing "Select Download Folder".
However, the strings mentioned in comment 5 are still not fixed. -> reopening;
changing summary.

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

oops. those weren't addressed by the attached patch. This is not going to make
the cut for tomorrow so -> .8

Comment 11

[Steffen Wilberg]

Attachment: patch for the remaining problems

I made this patch along Ben's lines. It fixes "My Downloads", "Remove Actions",
and the remove actions message.

Comment 12

[Steffen Wilberg]

Comment on attachment 132033 [details] [diff] [review]
patch for the remaining problems

>+    var bundle = document.getElementById("strings");
>+    var description = bundle.getString("myDownloads");
>...
>+      targetFolder.append(description);

>Index: mozilla/toolkit/mozapps/downloads/locale/unknownContentType.properties
>===================================================================
>+myDownloads=My Downloads

Is there a way to access the downloads.label entity in the pref-downloads.dtd
from javascript? Because it's the same:
<!ENTITY downloads.label	      "My Downloads">

Comment 13

[Mike Connor [:mconnor]]

no, its not possible.  Patch looks good though.

Comment 14

[Ben Goodger (use ben at mozilla dot org for email)]

r=me, and checked in. 

Comment 15

[Steffen Wilberg]

Comment on attachment 132033 [details] [diff] [review]
patch for the remaining problems

Thanks Ben.
(removing review request).

Comment 16

[Ben Goodger (use ben at mozilla dot org for email)]

Egg on my face for review+'ing this one. 

Steffen, your last patch caused the Options dialog to break... if you visit
Downloads, then change panels and then click OK, the dialog won't dismiss. 

I've checked in a fix for it already, but the reason is as follows:

- you referenced the 'document' object in the OK callback function. If the user
visits the page and then changes away from it, the OK callback is registered,
but the document it was created into has disappeared. So you need to create the
string bundle manually using the API. That's what I checked in. 

Comment 17

[Steffen Wilberg]

> Steffen, your last patch caused the Options dialog to break... if you visit
> Downloads, then change panels and then click OK, the dialog won't dismiss.
???
Wfm with yesterday's build.

But thanks a lot for the nice explanation.

Comment 18

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change