219216 - Problem with @->&#64; filter/munge and <input>

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Tobias Burnus]

Bug 120030 introduced the change that @ gets @.
At least in the "Assigned to" text field this gets inserted using @ (shown
like this in the input field).

Comment 1

[Dave Miller [:justdave]]

In which browsers?

Comment 2

[Dave Miller [:justdave]]

Hmm, testcase works in Mozilla, MSIE, and Safari on OS X...

perhaps it's getting escaped twice?

Comment 3

[Dave Miller [:justdave]]

OK, you forgot to say what page this was happening on, but I found it.  It's on
enter_bug and it's because the names are being fed via javascript, and they have
"FILTER html" on them instead of "FILTER js".

Patch coming shortly.

Comment 4

[Dave Miller [:justdave]]

Attachment: Patch

This fixes the immediate problem, but it reintroduces the spam situation (if
they're scanning the page source, which we know they do because of the volume
of spam the bugzilla.org mailserver rejects for [e-mail] :)  we should
probably split the mail addresses in the javascript and patch them together at
runtime when putting them into the box.

Comment 5

[timeless]

Comment on attachment 131464 [details] [diff] [review]
Patch

filter js needs to convert @ to \x40

Comment 6

[Dave Miller [:justdave]]

Oooh....

    components[0] = "Database backend";
    default_owners[0] = "justdave\x40syndicomm.com";
    components[1] = "Miscellaneous";
    default_owners[1] = "justdave\x40syndicomm.com";

Yep, it works.   It feeds "[e-mail]" into the edit box.

Comment 7

[Dave Miller [:justdave]]

Attachment: Patch v2

Add a @ -> \x40 to the js filter.

Comment 8

[Dave Miller [:justdave]]

Checking in Bugzilla/Template.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Template.pm,v  <--  Template.pm
new revision: 1.12; previous revision: 1.11
done
Checking in template/en/default/bug/create/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create.html.tmpl,v
 <--  create.html.tmpl
new revision: 1.21; previous revision: 1.20
done

Comment 9

[Dave Miller [:justdave]]

*** Bug 218585 has been marked as a duplicate of this bug. ***