219508 - processmail rescanall will not send multiple e-mails to the same address

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, defect)

Description

[Daniel Kolath]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0)
Build Identifier: 

When running processmail rescanall %seen and @sentmail are being declared as 
global variables.

The rescanall loop runs though each issue that needs mail sent.  When a user 
received an email $sent{'person'} gets set to 1.

When moving on to the next issue %sent never gets re-initialized.  So 
processing the next issue, if the user received an e-mail for a previous issue 
they will not receive any more e-mails.

Reproducible: Always

Steps to Reproduce:
1.execute processmail recanall where the same user needs to receive mail on 
multiple issues.
2.
3.

Actual Results:  
Only a single e-mail was received.

Expected Results:  
It should sent out an e-mail for every issue that you are supposed to be 
notified on.

Comment 1

[Dave Miller [:justdave]]

verified in 2.16.3

This does not affect the cvs tip, "rescanall" got a complete rewrite in 2.17.4
and is now done via sanitycheck.cgi and BugMail.pm, and it does properly
initialize %seen for each bug.

Comment 2

[Dave Miller [:justdave]]

Attachment: Patch against 2.16 branch

Comment 3

[J. Paul Reed [:preed]]

Comment on attachment 131627 [details] [diff] [review]
Patch against 2.16 branch

You didn't ask, but I saw the bugmail fly by...

r=preed

Comment 4

[Dave Miller [:justdave]]

Comment on attachment 131627 [details] [diff] [review]
Patch against 2.16 branch

anyone have a 2.16.x system they can try this on?

Comment 5

[Dave Miller [:justdave]]

Comment on attachment 131627 [details] [diff] [review]
Patch against 2.16 branch

er, that's what I get for leaving the window open too long. :)

Comment 6

[Dave Miller [:justdave]]

Checking in processmail;
/cvsroot/mozilla/webtools/bugzilla/Attic/processmail,v  <--  processmail
new revision: 1.81.2.1; previous revision: 1.81
done