219711 - about:config does not update when changing value

Status: VERIFIED DUPLICATE of bug 219456

(Core :: Preferences: Backend, defect)

Description

[Jerry Baker]

2003091704 trunk

1. Open about:config.
2. Change a value.

RESULT:
After you dismiss the dialog, the old value is still displayed on the
about:config page until you reload.

EXPECTED:
When you change the value, it should change the display of that value.

Comment 1

[[e-mail]]

Yes, we have no notifications :-(

Comment 2

[Ed Catmur]

Possibly a regression from bug 98533 - the dates check out: between
2003091601(UTC+01:00) and 2003091707(UTC+01:00)

Comment 3

[Dai Toyama]

Please change the OS to All.  I see the same problem using my Linux build.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6a) Gecko/20030920 Firebird/0.7+
(daihard; optimized for P4/SSE)

Comment 4

[[e-mail]]

Verified regression.

Darin removed support for disabling callbacks when loading pref files.

Unfortunately he failed to notice the bug that callbacks were disabled until
pref files were loaded.

Comment 5

[Alfred Kayser]

It seems that the old code even set the 'gCallbacksEnabled' flag to true,
just before reading the first preference file (allthough it is inited at false).
So, in effect the callbacks are never disabled.
So, just initting gCallbacksEnabled to PR_TRUE would fix the problem?
(See /modules/libpref/src/prefapi.cpp and nsPrefService.cpp)

The following function is always called with bCallbacks set to true:

PREF_EvaluateConfigScript(const char * js_buffer, size_t length,
    const char* filename, PRBool bGlobalContext, PRBool bCallbacks,
    PRBool skipFirstLine)
{
    JSBool ok;
    jsval result;
    JSObject* scope;
    JSErrorReporter errReporter;

    if (bGlobalContext)
        scope = gGlobalConfigObject;
    else
        scope = gMochaPrefObject;

    if (!gMochaContext || !scope)
        return JS_FALSE;

    errReporter = JS_SetErrorReporter(gMochaContext, pref_ErrorReporter);
    gCallbacksEnabled = bCallbacks;

    if (skipFirstLine)
    {
        ....
    }

    JS_BeginRequest(gMochaContext);
    ok = JS_EvaluateScript(gMochaContext, scope,
            js_buffer, length, filename, 0, &result);
    JS_EndRequest(gMochaContext);

    gCallbacksEnabled = PR_TRUE;        /* ?? want to enable after reading
user/lock file */
    JS_SetErrorReporter(gMochaContext, errReporter);
    return ok;
}

Comment 6

[Asa Dotzler [:asa]]

->darin.

Comment 7

[Darin Fisher]

*** This bug has been marked as a duplicate of 219456 ***

Comment 8

[[e-mail]]

Verified duplicate.