219828 - make fails with -w

Status: VERIFIED FIXED

(Camino Graveyard :: General, defect)

Description

[Daniel Parks]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.5b) Gecko/20030918 Camino/0.7+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.5b) Gecko/20030918 Camino/0.7+

The failure is in:

cd `make -f client.mk echo_objdir`

I think that the -w flag gets passed to make via an environment variable, or
something, and therefore make -f client.mk echo_objdir outputs a couple of extra
lines, which breaks cd.

It works if I don't use -w.

I think this is Camino specific:

daniel@gollum ~/Documents/Work/Camino/mozilla $ fgrep -r echo_objdir .
./camino.mk:    cd `$(MAKE) -f client.mk echo_objdir` && \
./camino.mk:    cd `$(MAKE) -f client.mk echo_objdir` && $(RM) -rf camino/build
./client.mk:echo_objdir:
fgrep: ./dist/MozillaDebug.app/Contents/MacOS/mangle: No such file or directory
fgrep: ./dist/MozillaDebug.app/Contents/MacOS/nsinstall: No such file or directory
fgrep: ./dist/MozillaDebug.app/Contents/MacOS/shlibsign: No such file or directory

Reproducible: Always

Steps to Reproduce:
1. Download recent tarball.
2. Updated it with CVS as specified at http://www.mozilla.org/, except that I
used camino.mk instead of client.mk.
3. make -w -f camino.mk 

Actual Results:  
make[4]: Leaving directory
`/Users/daniel/Documents/Work/Camino/mozilla/xpfe/bootstrap'
make[3]: Leaving directory `/Users/daniel/Documents/Work/Camino/mozilla'
make[2]: Leaving directory `/Users/daniel/Documents/Work/Camino/mozilla'
make[1]: Leaving directory `/Users/daniel/Documents/Work/Camino/mozilla'
cd `make -f client.mk echo_objdir` && \
make -C embedding/config && \
CONFIG_FILES=camino/Makefile ./config.status && \
make -C camino
/bin/sh: cd: make[1]:: No such file or directory
make: *** [build] Error 1
make: Leaving directory `/Users/daniel/Documents/Work/Camino/mozilla'


Expected Results:  
** BUILD SUCCEEDED **

daniel@gollum ~/Documents/Work/Camino/mozilla $ make -v
GNU Make version 3.79, by Richard Stallman and Roland McGrath.
Built for powerpc-apple-darwin6.0
Copyright (C) 1988, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99
        Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.

Report bugs to <[e-mail]>.

daniel@gollum ~/Documents/Work/Camino/mozilla $ sh --version
GNU bash, version 2.05a.0(1)-release (powerpc-apple-darwin6.0)
Copyright 2001 Free Software Foundation, Inc.
daniel@gollum ~/Documents/Work/Camino/mozilla $ uname -a
Darwin gollum.middle.earth 6.6 Darwin Kernel Version 6.6: Thu May  1 21:48:54
PDT 2003; root:xnu/xnu-344.34.obj~1/RELEASE_PPC  Power Macintosh powerpc

Comment 1

[Ludovic Hirlimann [:Usul]]

Confirming on darwin 6.8

Comment 2

[Ludovic Hirlimann [:Usul]]

replacing bash with zsh also break message is slightly different :
make[3]: Leaving directory `/Users/ludo/Documents/sources/moz/mozilla'
make[2]: Leaving directory `/Users/ludo/Documents/sources/moz/mozilla'
make[1]: Leaving directory `/Users/ludo/Documents/sources/moz/mozilla'
cd `make -f client.mk echo_objdir` && \
make -C embedding/config && \
CONFIG_FILES=camino/Makefile ./config.status && \
make -C camino
cd: too many arguments
make: *** [build] Error 1
make: Leaving directory `/Users/ludo/Documents/sources/moz/mozilla'

Comment 3

[Ludovic Hirlimann [:Usul]]

Attachment: Camino.mk patch

removing the CD solve the problem. I believe we're reaching more then 256 car
on the command line for build. Since all camino docs says you should be in the
mozilla source directory in order to build. I see ne reasons to keep this
change directory.

Comment 4

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 132527 [details] [diff] [review]
Camino.mk patch

removing this would break objdir support, and we're not going to do that.

Comment 5

[Brian Ryner (not reading)]

Attachment: patch #2

This fixes the problem without removing objdir support.  Despite what the
documentation says (it's a bit out of date in this regard), building in an
objdir is totally supported.

Comment 6

[Ludovic Hirlimann [:Usul]]

Brian, mike
youd'nt it be better to use the --no-print-directory option , when calling
calling for echo_objdir ?

Comment 7

[Ludovic Hirlimann [:Usul]]

btw bryner's patch works ...

Comment 8

[Ludovic Hirlimann [:Usul]]

Attachment: Using gnumakes option instead of a grep -v

Comment 9

[Ludovic Hirlimann [:Usul]]

Attachment: using Gnumake --no-print-directory insted of grep -v

Comment 10

[Josh Aas]

Ludovic's no-print-directory patch (2003-10-02 12:58:24) WFM. Compile finishes and the product 
seems to work just fine. Not sure why its better than bryner's. I didn't test bryner's patch. Ludovic 
- for my future knowlege, could you explain in a sentence or two what this code of bryner's does 
so I can understand why your patch is an improvement?

cd `$(MAKE) -f client.mk echo_objdir | grep -v "^$(MAKE)"` && \

Are we just waiting for another review for this to get checked in?

Comment 11

[Ludovic Hirlimann [:Usul]]

Explanation :
when -w is added before any directory vchange you get the message 
make ; changing to XXX
make workd
make ; changing to ..

When Camino.mk calls client.mk with okbjectdir thats a cd to "make ; changing to XXX
make workd
make ; changing to .." so the grep -v throws the make : lines away. But gnumake
can take an argument to do that and no need to call grep ...

Am I clear ?

Comment 12

[Mike Pinkerton (not reading bugmail)]

landed