220232 - Bugzilla::Bugmail dies if a bug summary is NULL

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, defect)

Description

[Dave Miller [:justdave]]

Found this on Bugscape trying to send unsent bugmail from sanitycheck...

It dies and leaves this in the log:
Can't find param named summary at Bugzilla/Config.pm line 124.

The bug it died on has a NULL summary (it was a recent import from another bug
database [ myk's fault ;) ] ).

The error is generated by PerformSubst(), which does a "defined" check on the
substitution string, and looks for a param by that name if you didn't define a
substitution string.

The real cuplrit here, I think, is that we even allow NULL summaries in the
database.  The short_desc column is not defined with "NOT NULL" in our schema.

Oops.

Comment 1

[Brendan Leber]

I've also experienced this problem with v2.17.6.  Adding myself to the CC list 
to monitor any progress.

Comment 2

[Bradley Baetz (:bbaetz)]

Why isn't the summary column NOT NULL?

Comment 3

[Dave Miller [:justdave]]

Attachment: Patch v1

We have a "mediumtext abuse" bug out there somewhere...  it would make sense to
tackle that at the same time if we're having to make a schema change to the
short_desc field at all...  this patch doesn't address that though.

Comment 4

[Bradley Baetz (:bbaetz)]

Comment on attachment 141436 [details] [diff] [review]
Patch v1

r=bbaetz

If this breaks INSERT/UPDATEs, then we'll fix the callers.

Comment 5

[Dave Miller [:justdave]]

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.263; previous revision: 1.262
done