220297 - Orphaned links in mail_help.html

Status: VERIFIED FIXED

(Documentation Graveyard :: Help Viewer, defect)

Description

[Mark Tyndall]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-GB; rv:1.4) Gecko/20030624
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5rc1) Gecko/20030923 I think

In
en-US.jar!locale/en-US/help/mail_help.html

Some links exist, but don't point to the heading (no <a name="foo"> at heading)

108: #account_settings_change "Changing the Settings for an Account",
    <h2> at line 319
1914: #import_address_book "Importing Address Books",
    <h2> at line 2383


Some links have been orphaned by the removal of the AOL/Webmail content.

411: #recovering_messages "Keeping Messages As New"

774: #unsending_messages "unsending a message"
784: #checking_status    "checking message status"



Reproducible: Always

Steps to Reproduce:
1. unzip en-US.jar
2. view locale/en-US/help/mail_help.html
3. find dead links

Actual Results:  
Actual results:
Dead links not pointing to content, or pointing to removed content.

Comment 1

[R.J. Keller]

Confirming bug. Definetely an issue.

Comment 2

[Mark Tyndall]

Attachment: Patch to revive/remove links as appropriate

This is my first time using diff.  I hope it works.

Comment 3

[R.J. Keller]

Comment on attachment 132202 [details] [diff] [review]
Patch to revive/remove links as appropriate

r=[e-mail]

Thanks for the patch!
I'll see if I can get someone to check this in.

Comment 4

[R.J. Keller]

--> Mark Tyndall

Comment 5

[R.J. Keller]

Mark: You're patch won't apply. Try using cvs diff:
cvs diff -u > patchName.diff

That should give you a patch in the directory that you're cd'ed to. It looks
like you used diff (and not cvs diff) to make this patch. cvs diff is much simpler.

If you can't get it to work, tell me and I'll create a new one based on this one.

Comment 6

[Mark Tyndall]

I don't have CVS yet at home - Win32 + 28.8 modem means I'll be d/l-ing at work
and sneakernetting home a CVS version for Win32 this week - I wouldn't want to
promise anything before Thu/Fri.

Please feel free to effect the change yourself if it's not too much trouble.

Comment 7

[Mark Tyndall]

Given the progress on bug 95770 I guess this bug either is, or soon will be,
invalid. I'm not sure if I can or should make this change though.

Comment 8

[R.J. Keller]

The mail/news XHTML documentation was checked in. Is this bug still valid?

Comment 9

[Daniel Wang]

checked links up to "Sending Messages" heading. all links seem to work

Comment 10

[Stefan [:stefanh]]

v