220694 - Location should appear in alarm dialog

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, enhancement)

Description

[Laurent Duperval]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624

Whe the alarm shows up, it give the time of the meeting or event, but it dosn't
show the location. In orter to view, you have to open the event. I think it
would be better to show the location in the dialog (or at least, allow it to be
configured).

Reproducible: Always

Steps to Reproduce:
1. Enter an event with a location
2. Enable alarm
3. When alarm appears, location isn't mentioned

Comment 1

[jason lowry]

I would like to "Second" the request for this feature. But I would like to add
support for also sending the location via email. Currently if you send an email
as an alarm then the location isn't included in the message.

Comment 2

[Bill Gianopoulos [:WG9s]]

Ditto on the whole thing.  This is the reason I switched back to outlook for my
calendar.  A pop-up alarm or e-mail that does not tell me the conference room
for a meeting or the phone number for the teleconference is completely useless.

Comment 3

[Bill Gianopoulos [:WG9s]]

Sorry for the bugspam, can we get this added to the alarm requirements list and
the associated tracker bug please?

Comment 4

[Peter Lairo]

If people (like me) include the location in the "note", having an extra line
taken up for the "location" would waste valuable space in the alarm notification
window. 

I therefore suggest that fields that *can* appear in the alarm notification
window should only appear *if* they are not blank.

BTW: The title & note texts currently appear too far to the right in the alarm
notification window. There is a whole area in the center that is unused, and
should be used to increase the amount of possible text. I'll attach a screenshot
(I know this should be another bug, but i don't have time to file one right now,
and i hope it can be easily fixed by someone here.)

Comment 5

[Peter Lairo]

Attachment: Screenshot showing some random other bug

Comment 6

[Robin Edrenius]

Attachment: Adds Location to the alarm-dialog

Comment 7

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 200511 [details] [diff] [review]
Adds Location to the alarm-dialog

This will have to wait. Anything that is not a regression fix or fixing a major blocker will have to wait until after 0.3a1.

Comment 8

[Robin Edrenius]

Attachment: remove un-necessary variable.

Made a change that was suggested by mvl per IRC.

Comment 9

[Michiel van Leeuwen (email: mvl+moz@)]

Can you provide a screenshot of the alarm dialog with the location filled in? We don't want to make the dialog too cluttered.

Comment 10

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 200545 [details] [diff] [review]
remove un-necessary variable.

I tried it, and it doesn't look to bad.
(Although I do think that the dialog wants a redesign)

r=mvl

Comment 11

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in