221039 - Separating knob in edit.html.tmpl

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Ludovic Dubost]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20030925
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20030925

This patch allows to separate the action information ('knob' I think.. I've no
idea what this stands for) from the edit template.. This would be better for
customization of the look of edit without having to change the knob part. This
could also allow to created different workflows in separate files depending on
some data like the products etc..



Reproducible: Always

Steps to Reproduce:

Comment 1

[Ludovic Dubost]

Attachment: Patch agains 2.17 head of Oct 2nd

Simple separation of the 'knob' code..

Comment 2

[Ludovic Dubost]

Comment on attachment 132528 [details] [diff] [review]
Patch agains 2.17 head of Oct 2nd

Asking for review

Comment 3

[Gervase Markham [:gerv]]

I currently have a patch to reorganise the way saved queries are done, in bug
179339, which Myk is also due to review. It has the side-effect of vastly
reducing the complexity of the knob in this file. I believe that it would clash
with this patch; I would therefore ask that my patch be reviewed in preference,
and then Ludovic could see if one like his was still needed.

Gerv

Comment 4

[Ludovic Dubost]

I think you misunderstound my patch or maybe I misued the 'knob' term.. My patch
is not in the search code but in the show_bug code.. The objective is actually
doing the same thing that is done in the search code which is to have the action
template separated from the show_bug template.. This would improve reuse..

So I think the patches can be reviewed separately.

Comment 5

[Christian Reis]

Ludovic, don't you want to supply bug to the PROCESS line? 

Comment 6

[Ludovic Dubost]

I don't understand what you mean. Can you elaborate ?

Comment 7

[Christian Reis]

Comment on attachment 132528 [details] [diff] [review]
Patch agains 2.17 head of Oct 2nd

nevermind, it works (tested). I think this is a good idea, given that the edit
template is quite long -- I did it locally in a slightly different way, but it
will help when I do a UI whack of this form.

Comment 8

[Ludovic Dubost]

So what's the next step ? Is somebody checking it in cvs ?
(my first checked in patch :) )
Ludovic

Comment 9

[Christian Reis]

Next step is obtaining approval, of course :-)

Comment 10

[Vlad Dascalu]

--> patch writer

Comment 11

[Dave Miller [:justdave]]

This does indeed touch the same code as the saved query simplification...

I want a few more eyes on this to see which one will be easier to put in first
with the least damage to the other...

Comment 12

[Dave Miller [:justdave]]

ok, wrong knobs...  Gerv's patch is the knobs on the query page, this patch is
the knobs on the show_bug page....    I gotta learn to look at the filenames. :)
 The code in those two places looks awfully similar. :)

Comment 13

[Christian Reis]

Checked in:

/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--
 edit.html.tmpl
new revision: 1.36; previous revision: 1.35
Checking in template/en/default/bug/knob.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/knob.html.tmpl,v  <--
 knob.html.tmpl

Ludovic, thanks for the patch -- remember, I'm expecting your Wiki work too :-)

Comment 14

[Christian Reis]

Attachment: additional patch to filterexceptions.pl

So Ludovic and I know that when moving variables around in templates,
filterexceptions.pl needs to be updated :-)

r=justdave, bustage fix checked in.