221481 - Quicksearch enhancements and allow to use quicksearch in the Bug# box of the footer

Status: RESOLVED DUPLICATE of bug 70907

(Bugzilla :: User Interface, enhancement)

Description

[Ludovic Dubost]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20030925
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20030925

This parch enhances quicksearch and the search boxes:

- Allow a ALL or OPEN bugs search
- allow to add keywords to the search fields (this means removing the blocking
of searches on keywords that are unknown)
- Enable quicksearch in the Bug# field

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Ludovic Dubost]

Attachment: Patch against 2.17 Head

Enhancements to the quicksearch functionality and search boxes

Comment 2

[Vlad Dascalu]

Some unofficial suggestions from a patch tester:

--> your patch contains the web.ref and the web.dev directories; a patch without
those would be much more helpful; to produce it, use "cvs diff -uN ." for
example in your web.dev directory instead of doing "diff -uN web.ref web.dev" or
something similar.
--> try to have an unique identation:

+ 			add_chart("short_desc","substring",w);
+                        add_chart("status_whiteboard","substring",w);

This will also remove changes like this one:

-                            }
+                           }

--> try to use the 4-space identation rule:

+function removeALL(value)
+{
+ var i = 0;
+ var str = value;
+ while (true || (i==4) ) {
+  i++;
+  if (str.indexOf("ALL ")!=0)
+   break;
+  str = str.replace("ALL " , "");
+ }
+ return str;
+}

Those are only (unofficial) suggestions after a first look. Thanks for
implementing these!

Comment 3

[Vlad Dascalu]

Oh, and inside templates, 2-space identation is used, so inserting the line
below requires to push all other lines to right with 2 spaces:

     [% ELSE %]
+     [% IF noactions != 1 %]
       <td valign="middle" align="right">

Comment 4

[Ludovic Dubost]

Thanks for the suggestions.. I'm not sure about the web.dev/web.ref thing..
The way I handle it is using patch -p1 -i to apply them without any problems..
But if the 'official' way for bugzilla patches is to have them without this
level of directory I can change that..

Concerning the identation in the following example

    [% ELSE %]
+     [% IF noactions != 1 %]
       <td valign="middle" align="right">

If I do add the 2 spaces in all the code then the diff will show much more lines
modified.. I understand the end result is not so nice.. but wouldn't it be a
trading good for bad ? 

What's the prefered way of bugzilla hackers ?

Ludovic

Comment 5

[Vlad Dascalu]

In http://bugzilla.org/developerguide.html it's said "HTML Templates should have
a 2-space indent.", and in http://bugzilla.org/reviewerguide.html , in the
Template Review Checklist section, "# check template style *  2 space indenting"
is specified.

(So it's highly unlikely to get a r+ on a patch that doesn't follow the indent
rule, even if it's done for "nobel" purposes :-) )

Comment 6

[Ludovic Dubost]

Ok.. who's doing a program that automatically reindents the code based on the
right conventions :)

I'll submit a new patch when I have time..

Comment 7

[Vlad Dascalu]

Apparently GNU does one - http://www.gnu.org/software/indent/indent.html :)

Comment 8

[Jouni Heikniemi]

Comment on attachment 132805 [details] [diff] [review]
Patch against 2.17 Head

Bitrotten, and there are also numerous indentation issues (with only one space
being used for indentation).

Comment 9

[Marc Schumann [:Wurblzap]]

This is at least blocked by bug 70907. Maybe it's even a duplicate of it, or
being fixed by it.

Comment 10

[A. Karl Kornel]

Suggest DUPLICATE of bug 70907.

ALL or OPEN bugs are apparently being covered already.  Keywords are apparently
also searched.  The search box in index.html is also being modified.  All of
these are mentioned in attachment 192270 [details] [diff] [review] of bug 70907.

Comment 11

[Max Kanat-Alexander]

Yeah, with how many different issues there are in the original report, it's a
duplicate. For just the "bug # box" thing I would have marked it as [blocker
will fix].

*** This bug has been marked as a duplicate of 70907 ***