221827 - Missing Bug ID shouldn't be handled as Invalid Bug ID

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[timeless]

Steps to reproduce:
don't include a &bugid= for &action=enter

Actual Results:
Invalid Bug ID

The 'bug number' is invalid. It is neither a bug number nor an alias to a bug 
number. If you are trying to use QuickSearch, you need to enable JavaScript in 
your browser. To help us fix this limitation, add your comments to bug 70907.

Expected Results:
Missing Bug ID

You didn't enter a bug id. Please enter one now: [     ] <Create Attachment>

Additionally, you passed bug_id=221826 which was unrecognized by this form.

Comment 1

[Frédéric Buclin]

I have updated the error message a bit, but it still says "invalid bug number".
Easy to fix.

Comment 2

[Frédéric Buclin]

Attachment: trivial patch

Change the title from "Invalid Bug ID" to "Missing Bug ID" if the bug number is
not given.

Comment 3

[Vlad Dascalu]

Comment on attachment 170189 [details] [diff] [review]
trivial patch

"Missing" would be unappropiate for the "invalid_bug_id_or_alias" error.

Comment 4

[timeless]

Attachment: rename identifiers

Comment 5

[Vlad Dascalu]

Comment on attachment 276382 [details] [diff] [review]
rename identifiers

I'm not sure we can reach that case without tweaking the URL, so probably it should be a code error.

But it's still a nice improvement (maybe the code error thing should be another bug).

Comment 6

[Vlad Dascalu]

Yeah, we can reach it.

Comment 7

[Frédéric Buclin]

Comment on attachment 276382 [details] [diff] [review]
rename identifiers

>Index: Bugzilla/WebService/Constants.pm

>-    invalid_bug_id_or_alias     => 100,
>-    invalid_bug_id_non_existent => 101,
>+    improper_bug_id_field_value     => 100,
>+    bug_id_does_not_exist => 101,
>     bug_access_denied           => 102,
>     invalid_field_name          => 108,

Don't break the indentation.

Comment 8

[Max Kanat-Alexander]

Not approved for 3.0 because this kind of template change is unnecessary on the branch, and just makes life harder for localizers.

Comment 9

[timeless]

Comment on attachment 276382 [details] [diff] [review]
rename identifiers

mozilla/webtools/bugzilla/showdependencytree.cgi 	1.51
mozilla/webtools/bugzilla/Bugzilla/Bug.pm 	1.199
mozilla/webtools/bugzilla/Bugzilla/WebService/Constants.pm 	1.8
mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl 	1.229

Comment 10

[Frédéric Buclin]

This patch never landed on the 3.0 branch.