221885 - [minimo] add --disable-cookies build option

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Darin Fisher]

now that the cookie service has been moved into necko, we may want to add a
configure option to disable the building of cookies.  thunderbird might want
this option (until it starts using the GRE), and other gecko embedders might as
well.

see bug 210561 for more info on the move from extensions/cookie to netwerk/cookie.

Comment 1

[Scott MacGregor]

I would definetly be interested in leveraging such a flag for thunderbird.

Comment 2

[[e-mail]]

looking ahead... right now, cookies will be operational in thunderbird
(presuming you don't have a cookies disabled pref in all.js). if/when
thunderbird uses the GRE, they will also be operational by default.

to fix this, you probably want to add the "network.cookie.cookieBehavior"
integer pref to all.js, and set it to 2 (disable). of course users could
override this pref, so if you really want to nuke cookies, you can make your own
implementation of nsICookiePermission that just blanket rejects everything. but
i would hope the pref is enough :)

Comment 3

[Doug Turner (:dougt)]

moving minimo bugs to the new bugzilla product.

Comment 4

[[e-mail]]

Attachment: patch

something a little like this?

(this unconditionally exports the public cookie headers - necko requires them.
is that ok?)

Comment 5

[[e-mail]]

Attachment: supplement

... and with this, it actually works. thanks biesi.

(interesting flaw with ccache... it must've pulled nsNetModule.o from cache,
since nothing had apparently changed. it wont've known about the missing cookie
headers. caveat emptor).

Comment 6

[[e-mail]]

er, nevermind that slur on ccache. pebcak.

Comment 7

[[e-mail]]

since minimo doesn't have review flags... darin, feel free to look at this when
you have some time :)

Comment 8

[Darin Fisher]

-> Browser:Networking

Comment 9

[Darin Fisher]

Comment on attachment 152895 [details] [diff] [review]
supplement

r+sr=darin

Comment 10

[Darin Fisher]

Comment on attachment 152891 [details] [diff] [review]
patch

i think you need to declare NECKO_COOKIES in autoconf.mk.in so it will be seen
by the Makefiles.

otherwise, this patch looks good to me.  you should get cls, bryner, or
bsmedberg to give final review for build changes.

Comment 11

[[e-mail]]

Attachment: autoconf supplement

ah! thanks, yeah, i didn't know about autoconf.mk.in. (i had temporarily
assumed the reason the makefiles weren't picking up the change was because i
hadn't regenerated |configure|).

Comment 12

[[e-mail]]

Comment on attachment 152891 [details] [diff] [review]
patch

bsmedberg, could you take a look at these three patches? thanks!

Comment 13

[Benjamin Smedberg]

Comment on attachment 152891 [details] [diff] [review]
patch

>+[  --disable-cookies
>+                          Disable cookie support],

You don't need this on two lines, that's only for configure options that are
too long
for a single line. Please condense.

Comment 14

[[e-mail]]

condensed, and checked in. this will be needed on the aviary branch, per mscott
(http://bugzilla.mozilla.org/show_bug.cgi?id=250931#c1).

Comment 15

[[e-mail]]

Attachment: necko-config.h.in change

necko-config.h needs to know about NECKO_COOKIES too.

Comment 16

[Darin Fisher]

Comment on attachment 153344 [details] [diff] [review]
autoconf supplement

r+sr=darin

Comment 17

[Darin Fisher]

Comment on attachment 153642 [details] [diff] [review]
necko-config.h.in change

r+sr=darin

Comment 18

[Mike Kaply [:mkaply]]

dwitte - can you put this on 1.7 as well in case there is a minimo release from
there?

Thanks

Please mark fixed1.7.x when done.