221886 - remove nsCCookieManager.h in favor of nsNetCID.h

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Darin Fisher]

now that the cookie service (aka cookie manager) live in necko, we should
eliminate nsCCookieManager.h in favor of using nsNetCID.h.  LXR indicates that
camino includes nsCCookieManager.h, but otherwise this should be a trivial
change to make.

Comment 1

[[e-mail]]

Attachment: move contractid's/cid's to nsNetCID.h

Comment 2

[[e-mail]]

Comment on attachment 133890 [details] [diff] [review]
move contractid's/cid's to nsNetCID.h

note the disagreeing uuid/cid's between the following:

http://lxr.mozilla.org/seamonkey/source/netwerk/cookie/public/nsICookieService.
idl#77
http://lxr.mozilla.org/seamonkey/source/netwerk/cookie/public/nsICookieService.
idl#174

do we care about that...?

Comment 3

[[e-mail]]

Attachment: clean up REQUIRES lines in makefiles

most modules don't need 'cookie' anymore...

Comment 4

[Darin Fisher]

Comment on attachment 133890 [details] [diff] [review]
move contractid's/cid's to nsNetCID.h

>Index: netwerk/cookie/public/nsICookieService.idl
>  */
>+
> [scriptable, uuid(011C3190-1434-11d6-A618-0010A401EB10)]
> interface nsICookieService : nsISupports

nit: don't add that newline... prevailing necko style doesn't
have that newline :)

r+sr=darin

Comment 5

[Darin Fisher]

though it is not done in all cases, can you also please add a comment above each
class declaration in nsNetCID.h explaining what interfaces each class
implements.  there are plenty of examples of how this is annotated in that file.
 thx!

Comment 6

[Darin Fisher]

Comment on attachment 133891 [details] [diff] [review]
clean up REQUIRES lines in makefiles

r+sr=darin

Comment 7

[[e-mail]]

Attachment: updated nsNetCID.h patch

adds comments to nsNetCID.h... thanks for review!

Comment 8

[Darin Fisher]

-> dwitte

Comment 9

[[e-mail]]

fixed on trunk.