222042 - mail compose window zlevel is unconstrained

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Dan M]

The Mail Compose window, with a normal z-level, is allowed to drop behind an
alwaysLowered browser window. (Bad).

Current trunk build.
0) Install the window z-level altering extension from bug 42557.
   (Heh. A little bit of advertising, there.)
1) Launch Mozilla (I'm assuming it opens a browser window by default).
2) Set the browser window's level to "lowered."
3) Open the Mail & Newsgroups window.
4) Open a new Message window.
5) Close the Message window from step 4.
6) Open another "new" Message window.
   (operational note: it's really the same window).
7) Mouseclick the browser window.
   -- the Message window is sent behind the browser window.

This may be related in some way to bug 204761 (which I can't reproduce). This
bug, though, is specific to the Mail Compose window. That window isn't actually
deleted when it's "closed"; it's only hidden. This bug is related to the Compose
window's unique close/reopen methodology.

Comment 1

[Dan M]

Attachment: register compose window before showing it

Registering the window before showing it can only be a good thing. But actually
I'm surprised this fixes the bug. I was seeing scary stuff at the widget level
that made it seem a lot harder. Still, this does the trick...

Note the change to nsWindowMediator isn't strictly necessary: that error wasn't
being triggered. But the extra check seems like a good idea. It'd be very
confusing to register one window twice.

Comment 2

[Dan M]

PS -- in the steps to reproduce, nos. 4 and 6, I opened the Compose Message
window by clicking the "Compose" button in the Mail & Newsgroups window, not by
making a menu selection from the browser window. That's probably important.

Comment 3

[(not reading, please use [e-mail] instead)]

Comment on attachment 133215 [details] [diff] [review]
register compose window before showing it

sr=sspitzer, assuming the cached compose window still works.

Comment 4

[Dan M]

Seems to! On Windows, at least. Patch is checked in to the trunk.