Closed
Bug 222204
Opened 21 years ago
Closed 21 years ago
A mailto: link for the reporter would be very useful.
Categories
(Bugzilla :: User Interface, enhancement)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: mlassau, Assigned: goobix)
Details
Attachments
(1 file, 2 obsolete files)
592 bytes,
patch
|
kiko
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20030925
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20030925
Additional comments include a mailto: link for the user who entered the comments.
The same functionality would be even more helpful for the initial reporter.
This could occur at the top of the page:
add a link to "Reporter: Joe@mozilla.org (Joe Bloggs)"
AND/OR above the desciption:
eg have "Description: (From Joe Bloggs)" similar to the "Additional Comment #1
From Joe Bloggs"
Reproducible: Always
Steps to Reproduce:
Reporter | ||
Updated•21 years ago
|
Version: unspecified → 2.17.1
Assignee | ||
Comment 1•21 years ago
|
||
Assignee | ||
Comment 2•21 years ago
|
||
Confirming.
Assignee: myk → jocuri
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Updated•21 years ago
|
Status: NEW → ASSIGNED
Component: Creating/Changing Bugs → User Interface
Assignee | ||
Updated•21 years ago
|
Attachment #133365 -
Flags: review?(kiko)
Comment 3•21 years ago
|
||
Comment on attachment 133365 [details] [diff] [review]
V1
Looks simple enough.
I considered spambots, but I don't think a mailto: makes any difference when we
have the email address right there anyway :-)
Attachment #133365 -
Flags: review?(kiko) → review+
Comment 4•21 years ago
|
||
Comment on attachment 133365 [details] [diff] [review]
V1
Seems like the comments just show the real name for the link text. This would
make it inconsistent with those, wouldn't it?
Attachment #133365 -
Flags: review?(myk)
Comment 5•21 years ago
|
||
I don't think that's a very useful consistency to enforce <wink> -- the comments
are miles away from the reporter name, and if we change the interface (as I
would very much like to do) to have them closer, we can make it consistent then.
Comment 6•21 years ago
|
||
Comment on attachment 133365 [details] [diff] [review]
V1
>- [% bug.reporter.identity FILTER html %]
>+ <a href="mailto:[% bug.reporter.email FILTER html %]">
>+ [% bug.reporter.email FILTER html %]</a>
>+ ([% bug.reporter.name FILTER html %])
You should linkify the whole identity rather than just the email address.
"identity" does more than just munge email and name together; it checks to see
if the user has a name first. The code in this patch can result in something
like the following, which won't look good:
<a href="mailto:foo@bar.com">foo@bar.com</a> ()
Attachment #133365 -
Flags: review?(myk) → review-
Assignee | ||
Comment 7•21 years ago
|
||
Comment #3 - regarding spambots, "FILTER html" eliminates the @ sign from the
html source so the "protection" againest bots is identical to the protection
that we currently have on "Additional Comments".
I agree with comment #5 (inconsistency is already present and it can be useful
in some situations) and with comment #6.
Assignee | ||
Updated•21 years ago
|
Attachment #133365 -
Attachment is obsolete: true
Assignee | ||
Comment 8•21 years ago
|
||
(I've uploaded the wrong diff)
Attachment #133406 -
Attachment is obsolete: true
Assignee | ||
Updated•21 years ago
|
Attachment #133407 -
Flags: review?(kiko)
not that i care, but this will make it *harder* for people to email me.
this might be a good thing.
Comment 10•21 years ago
|
||
Comment on attachment 133407 [details] [diff] [review]
The correct V2
Err, what about the parenthesis?
Assignee | ||
Comment 11•21 years ago
|
||
In reply to comment #9: When viewing the results of a bug-search, we already
have a link called "Send Mail to Bug Owners" that represents a href mailto link,
which already is in the CVS and breaks your approach of using shadows accounts
(watchers) in order to receive mail.
In reply to comment #10: the implementation of the patch version 2 is "above"
the layer of code that adds the "(" and ")" thing. If those are set in the
.identity property, then we display them, otherwise we don't. The CVS tip
currently uses a different format (see for example the reporter in
http://landfill.bugzilla.org/bugzilla-tip/show_bug.cgi?id=333 ).
Comment 12•21 years ago
|
||
Comment on attachment 133407 [details] [diff] [review]
The correct V2
Right.
Attachment #133407 -
Flags: review?(kiko) → review+
Assignee | ||
Updated•21 years ago
|
Flags: approval?
Reporter | ||
Comment 13•21 years ago
|
||
Maybe I'm too late, but I just realised that a mailto: for the "Assigned To"
field would also be useful.
Please let me know if I should log this as a separate enhancement request.
I realise that Bugzilla is primarily designed for mozilla.org and other Open
Source projects, and therefore encouraging private emails may not be desirable
for all installations.
This could be addressed by a config option turning mailto: on or off.
Please also see bug 223507 for another suggested mailto: enhancement.
Comment 14•21 years ago
|
||
eh, why not? :)
We can always revisit this when we redo the UI if people don't like it.
Flags: approval? → approval+
Updated•21 years ago
|
Target Milestone: --- → Bugzilla 2.18
Assignee | ||
Comment 15•21 years ago
|
||
Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v <--
edit.html.tmpl
new revision: 1.35; previous revision: 1.34
done
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•