222807 - hyperlinks in svg don't work

Status: RESOLVED WORKSFORME

(Core :: SVG, defect)

Description

[John Ellson]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6a) Gecko/20030813
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6a) Gecko/20030813

The page
http://www.croczilla.com/svg/w3c-conformance-suite/structure-basicG-BE-03-ps.html
claims that Mozilla+SVG passes the test, but the anchor around
the Copyright text in the SVG doesn't work.

Anchors also don't work around SVG graphics objects.  These anchors
work in both Amaya and in the Adobe plugin.  e.g.
http://www.graphviz.org/bug/hello-world.xml




Reproducible: Always

Steps to Reproduce:
1.Try to follow any hyperling in SVG
2.
3.

Actual Results:  
nothing

Expected Results:  
follow the link

Comment 1

[Boris Zbarsky [:bzbarsky]]

Same error as in bug 222785 keeps the svg from even loading, making it
impossible to test in a current build...

Comment 2

[Boris Zbarsky [:bzbarsky]]

Just tested, and there are no chunked responses involved here, unlike bug  	222785

Comment 3

[John Ellson]

I failed to make clear that this was with SVG_20020806_BRANCH, not with TRUNK.

I can't see why this would have anything to do with #222785,
but then I can't get current CVS to build either.

Comment 4

[John Ellson]

Thanks for the merge, Alex.
Just confirming that this bug exists in today's (Oct 21) build from CVS,
but you probably knew that already....

Comment 5

[Alex Fritze]

John:
The links on http://www.graphviz.org/bug/hello-world.xml work fine on Windows
with today's (22. Oct) build. I can't test on Linux at the moment, but it should
work cross-platform, because it's implemented in XBL. Have you modified your 
dist/bin/res/ua.css in any way or removed dist/bin/res/svg.css?

Comment 6

[John Ellson]

No, no mods to: dist/bin/res/ua.css dist/bin/res/svg.css,
infact no local mods at all other than the changes required for
ttf fonts in defaults/pref/unix.js

I'm rebuilding today's (Oct 22) now to reconfirm.  I'm using these
options in .mozconfig :

ac_add_options --prefix=/usr
ac_add_options --enable-crypto
ac_add_options --enable-calendar
ac_add_options --enable-xft
ac_add_options --enable-svg
ac_add_options --enable-svg-renderer-libart
ac_add_options --enable-optimize=-O2
ac_add_options --enable-strip
ac_add_options --disable-pedantic
ac_add_options --disable-debug
ac_add_options --disable-logging
mk_add_options MOZ_INTERNAL_LIBART_LGPL=1
MOZ_INTERNAL_LIBART_LGPL=1

Comment 7

[John Ellson]

confirming that the bug still exists in my linux build of Oct 22 CVS tree.

Comment 8

[Alex Fritze]

Does your mousepointer change shape when you mouseover the anchors in
hello-world.xml?
If no then it looks like the svg stylesheet dist/bin/res/svg.css doesn't get
applied for some reason. 
If yes then the problem is probably with the xbl binding for the <svg:a> element
(mozilla/layout/svg/base/src/resources/content/svgBindings.xml).

Comment 9

[John Ellson]

> Does your mousepointer change shape when you mouseover the anchors in
hello-world.xml?

No.

> If no then it looks like the svg stylesheet dist/bin/res/svg.css doesn't get
applied for some reason. 

I assume this is the file taht gets installed as: /usr/lib/mozilla-1.6a/res/svg.css

How is it supposed to "get applied" ?    There are no references to svg.css
from:
    cd /usr/lib/mozilla-1.6a/res/svg.css; grep svg.css

I note that html.css is referenced from ua.css, but svg.css is not.

Comment 10

[Alex Fritze]

There should be a line "@import url(resource:/res/svg.css);" in ua.css. It gets
put there by the perl script 'mozilla/layout/svg/base/src/install-svg-css.pl'.
Correct execution of the script is somewhat dependent on the build order. The
only thing I can think of is that your particular build options subtly change
the build order. My Windows & Linux builds are both ok.

Comment 11

[John Ellson]

OK. this patch to the installation provides a work-around:
===========================
--- mozilla-1.6a/res/ua.css.old 2003-10-23 09:43:14.058023971 -0400
+++ mozilla-1.6a/res/ua.css     2003-10-23 09:47:07.534580333 -0400
@@ -37,6 +37,7 @@
 @import url(resource://gre/res/html.css);
 @import url(chrome://global/content/xul.css);
 @import url(resource://gre/res/quirk.css);
+@import url(resource://gre/res/svg.css);
  
 @namespace parsererror url(http://www.mozilla.org/newlayout/xml/parsererror.xml);
 
==========================

Now the elipse outlines are sensitive, but not the whitespace or the
text inside the ellipse.  Perhaps that should be the subject of
a separate bug report?

Can you send me a copy of your .mozconfig so that I can try to get
mine working without the patch? 

Also, when does the perl script get called? During build, install, or startup?

Comment 12

[Alex Fritze]

> Now the elipse outlines are sensitive, but not the whitespace or the
> text inside the ellipse.  Perhaps that should be the subject of
> a separate bug report?

Yes, please do file one.

> Can you send me a copy of your .mozconfig so that I can try to get
> mine working without the patch? 

ac_add_options --enable-svg
ac_add_options --enable-svg-renderer-libart
mk_add_options MOZ_INTERNAL_LIBART_LGPL=1
MOZ_INTERNAL_LIBART_LGPL=1
ac_add_options --enable=crypto
ac_add_options --enable-extensions=all
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/debug_build/

> Also, when does the perl script get called? During build, install, or startup?

It gets installed by the libs:: target in layout/svg/base/src/Makefile.in.
Maybe adding the call to the install:: target will fix your build?

Comment 13

[John Ellson]

> Maybe adding the call to the install:: target will fix your build?

I do:
  make -f config.mk checkout
  make -f config.mk build

Then, because config.mk doesn't have an "install" target, nor "install::" I do:
  su
  make install

Is the install target called something other than "install" in config.mk ?

Comment 14

[John Ellson]

Please ignore comment #13.

    make -f client.mk install

seems to be working now.   

Perhaps that was the root cause of my problem all along...

Comment 15

[John Ellson]

No, its not me.

   make -f client.mk install

doesn't add the import of svg.css to res/ua.css

Comment 16

[Jonathan Watt [:jwatt]]

Is this bug still valid? If so can it be marked as NEW? 

Comment 17

[Alex Fritze]

This WFM, so I'm just going to assume it works for everybody else as well and
close it. John: Feel free to reopen if you've still got this problem.