Closed Bug 223128 Opened 20 years ago Closed 20 years ago
Icon Decoder should not call streamlistener methods directly
(os/2 version of bug 221593) calling OnStartDecode and friends from AsyncOpen is a bad idea, callers don't like it. also Suspend and Resume are not implemented. bug 221593 has a windows patch, maybe this can be used for os/2 as well
The Windows patch should work for OS/2. That was an OS/2 port.
Assignee: jdunn → mkaply
Comment on attachment 133777 [details] [diff] [review] OS/2 version all of the comments at http://bugzilla.mozilla.org/show_bug.cgi?id=221593#c7 apply to this patch too, I think
Attachment #133777 - Flags: review?(cbiesinger) → review-
Yep. I'll post a new patch.
Attachment #136254 - Flags: review?(cbiesinger)
Comment on attachment 136254 [details] [diff] [review] Win code ported to OS/2 - * Contributor(s): + * Contributor(s): don't add trailing whitespace... (twice) otherwise r=biesi
Attachment #136254 - Flags: review?(cbiesinger) → review+
The reason that trailing whitespace is there is because I actually took the Windows version of the file and put the OS/2 changes into it. The Windows files has multiple cases of trailing whitespace. I'll remove those for the OS/2 version if you remove them for the Windows version :)
Fix checked in.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.