os/2 nsIconDecoder should not call streamlistener methods directly

RESOLVED FIXED

Status

()

Core
ImageLib
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: Biesinger, Assigned: mkaply)

Tracking

Trunk
x86
OS/2
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(os/2 version of bug 221593)

calling OnStartDecode and friends from AsyncOpen is a bad idea, callers don't
like it. also Suspend and Resume are not implemented.

bug 221593 has a windows patch, maybe this can be used for os/2 as well
(Assignee)

Comment 1

14 years ago
The Windows patch should work for OS/2. That was an OS/2 port.
(Assignee)

Comment 2

14 years ago
Created attachment 133777 [details] [diff] [review]
OS/2 version

Updated

14 years ago
Attachment #133777 - Flags: review?(cbiesinger)

Comment 3

14 years ago
.
Assignee: jdunn → mkaply
Comment on attachment 133777 [details] [diff] [review]
OS/2 version

all of the comments at http://bugzilla.mozilla.org/show_bug.cgi?id=221593#c7
apply to this patch too, I think
Attachment #133777 - Flags: review?(cbiesinger) → review-
(Assignee)

Comment 5

14 years ago
Yep. I'll post a new patch.
(Assignee)

Comment 6

14 years ago
Created attachment 136254 [details] [diff] [review]
Win code ported to OS/2
Attachment #133777 - Attachment is obsolete: true
(Assignee)

Updated

14 years ago
Attachment #136254 - Flags: review?(cbiesinger)
Comment on attachment 136254 [details] [diff] [review]
Win code ported to OS/2

- * Contributor(s):
+ * Contributor(s): 

don't add trailing whitespace... (twice)

otherwise r=biesi
Attachment #136254 - Flags: review?(cbiesinger) → review+
(Assignee)

Comment 8

14 years ago
The reason that trailing whitespace is there is because I actually took the
Windows version of the file and put the OS/2 changes into it. The Windows files
has multiple cases of trailing whitespace.

I'll remove those for the OS/2 version if you remove them for the Windows version :)
(Assignee)

Comment 9

14 years ago
Fix checked in.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.