223128 - os/2 nsIconDecoder should not call streamlistener methods directly

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

(os/2 version of bug 221593)

calling OnStartDecode and friends from AsyncOpen is a bad idea, callers don't
like it. also Suspend and Resume are not implemented.

bug 221593 has a windows patch, maybe this can be used for os/2 as well

Comment 1

[Mike Kaply [:mkaply] (Out until 9/29)]

The Windows patch should work for OS/2. That was an OS/2 port.

Comment 2

[Mike Kaply [:mkaply] (Out until 9/29)]

Attachment: OS/2 version

Comment 3

[timeless]

.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 133777 [details] [diff] [review]
OS/2 version

all of the comments at http://bugzilla.mozilla.org/show_bug.cgi?id=221593#c7
apply to this patch too, I think

Comment 5

[Mike Kaply [:mkaply] (Out until 9/29)]

Yep. I'll post a new patch.

Comment 6

[Mike Kaply [:mkaply] (Out until 9/29)]

Attachment: Win code ported to OS/2

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 136254 [details] [diff] [review]
Win code ported to OS/2

- * Contributor(s):
+ * Contributor(s): 

don't add trailing whitespace... (twice)

otherwise r=biesi

Comment 8

[Mike Kaply [:mkaply] (Out until 9/29)]

The reason that trailing whitespace is there is because I actually took the
Windows version of the file and put the OS/2 changes into it. The Windows files
has multiple cases of trailing whitespace.

I'll remove those for the OS/2 version if you remove them for the Windows version :)

Comment 9

[Mike Kaply [:mkaply] (Out until 9/29)]

Fix checked in.