223208 - [patch] New bookmark manager info panel fixes

Status: RESOLVED WONTFIX

(Camino Graveyard :: Bookmarks, defect)

Description

[Ludovic Hirlimann [:Usul]]

This prevents titles of bookmark from overlapping the "close/minimize/maximize"
buttons on the Bookmark Info panel.

Comment 1

[Ludovic Hirlimann [:Usul]]

Attachment: david's patch

Comment 2

[S Woodside]

Doesn't work. Try entering all M's (capital "M" is the widest character, hence
the name "em dash") for a title. I think this is a cocoa bug, is it fixed in
panther?

Comment 3

[Jasper]

This issue is fixed under Panther.

Comment 4

[S Woodside]

recommend close as WFM.

Comment 5

[Mike Pinkerton (not reading bugmail)]

wait, what about the patch?

Comment 6

[S Woodside]

I guess that it would still help on 10.{1,2}. But the proposed patch isn't a
good solution, since a name of 43 "M"s will still overrun the buttons. I guess
it could be better to reduce the length to whatever number of "M"s will not
overrun. ideally it should measure the width of the string in question though.

Comment 7

[Mike Pinkerton (not reading bugmail)]

would a shorter max fix it? if it's simple to fix on 10.1/2, then why not? How
about 40? That should be MORE than plenty, eh?

Comment 8

[S Woodside]

I think that "M" is usually the widest character. So anything less than 43
characters would be a workaround.

Comment 9

[Ludovic Hirlimann [:Usul]]

Mike would you commit a Max at 40 ?

Comment 10

[Ludovic Hirlimann [:Usul]]

Comment on attachment 133832 [details] [diff] [review]
david's patch

Mike Could you check this one with a value of 40 ?

Comment 11

[Mike Pinkerton (not reading bugmail)]

so with a string of all 'M's, the best i can get is 25 characters to not
overflow. not even sure how that localizes to say, japanese. and 25 characters
isn't really all that much for strings that aren't all 'M'.

why not just allow the window to resize and chalk it up to an os bug?

Comment 12

[Mike Pinkerton (not reading bugmail)]

not going to fix this. workaround: resize the window.