Here's a better veresion of BrowserWindowNib. It fixes the button alignment, some tooltips, and puts an icon on the separator button.
is this dependent on other code changes? just putting this nib in makes the folder and bookmark buttons not be in the right place in the window, and the mAddBookmarkButton is connected to the wrong button in the UI. am i missing something?
Comment on attachment 133945 [details] BrowserWindow.nib.tgz yes, yes indeed you are. my bad - I should have tested this. You'll almost certainly need the patch for bug 223209 - at least the part where it gets rid of the splitViewDidResizeSubviews: method in BookmarkViewController, which is programatically moving the buttons around (which I didn't notice until weeks after I started trying to figure out how those buttons were aligned). As for why the nib button isn't hooked up correctly - I have no idea. My build works as expected, but the NIB button clearly isn't hooked up right . . . I'm gonna obsolete this until tonight.
Attachment #133945 - Attachment is obsolete: true
Could we then also hook up the new info button icon? info_on.tif. It's already in the project. Just to fix that issue right away. Coudl you also fix the following issue. Make sure that the right bookmarksview is set to always have something selected otherwise user can open the info on the root bookmarks folders which is stupid since we aren't even alowed to edit the name and such.
Created attachment 134059 [details] slightly fixed BrowserWindow.tgz ok, with the patch for bug 223209 and this nib the bookmark view looks OK.
I'm nitpicking, but I think that this method: -(BOOL) find:(BOOL)searchBack should have a better name, e.g. -(BOOL) findAndSearchBackwards:(BOOL)searchBack Also, I noticed that the search doesn't wrap around as it should.
Oops, sorry that comment was supposed to be for a different bug.
i don't like the fact that the thick border was added as part of this nib fixup. It looks like we're wasting a lot of space that could be used. why was this done?
landed w/ thin border
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.