223416 - spell checker improperly handles length changes in replaced words

Status: RESOLVED WORKSFORME

(MailNews Core :: Composition, defect)

Description

[Jason House]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20030925
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20030925

Notice how in the reproduce steps, you're effectively adding two letters to the
word before where the problem occurs.  It appears that the scanning the
remaining text begins at 2 letters after the end of "relatity", thus skipping
the space and the letter "n".  I suspect that there is somehow a mixing of
positions in the original/corrected blocks of text...

Reproducible: Always

Steps to Reproduce:
1. compose an e-mail with a body of "relatity newsgroup"
2. start the spell check through your favorite method
3. replace "relatity" with "relativity"

Actual Results:  
the "ewsgroup" portion of "newsgroup" gets highlighted and suggests changing it
to "newsgroup"

Expected Results:  
it should not have found any other spelling errors

Comment 1

[Benjamin Smedberg]

wild guess: fallout from the JS regexp rewrite?

Comment 2

[timeless]

if this isn't addressed by late monday i'll look at it tuesday. note that
there's a thing about null captures which was changed by the regexp landing
(correctness).

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

afaik, the spellchecker doesn't use js to replace words, but textservices.
http://lxr.mozilla.org/seamonkey/source/editor/txtsvc/src/nsTextServicesDocument.cpp#2256

Comment 4

[Asa Dotzler [:asa]]

*** Bug 229931 has been marked as a duplicate of this bug. ***

Comment 5

[(not reading, please use [e-mail] instead)]

sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.

Comment 6

[Matt Caywood]

WFM Thunderbird 2.0, Firefox 3.0.