223700 - only allow drag text to create a bookmark int he bm manager if it's a valid URL

Status: VERIFIED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Chris Petersen]

Build: 2003102409
Platform: OS X 10.3
Expected Results: No bookmark should be created if I select and drag text from
the  bookmark sheet to the bookmark window
What I got: It create a bookmark with a invalid url. Ideally, the user shouldn't
be able to create a bookmark this way (especially a bogus one)

Steps to reproduce:

1) Select Manage Bookmarks
2) Select either Add Page to Bookmarks or Add Bookmark Folder from the Bookmarks
window
3) In the sheet that appears, place focus in the name field and select all. Now,
drag and drop this selection into the bookmarks window.
4) Notice a bookmark is created but doesn't contain a url. This type of drag and
 drop task should be ignored by the app when the dragging into the bookmark window.

Comment 1

[Jasper]

First of allI think you are doing something I wouldn't even think of doing!
Secondly you are dragging the name field and not the bookmark so it's not
strange that you only get the name.

As I mentioned in an other bug. I really think we should take out the capability
to create a bookmark when we are in the bookmarks manager.
- we don't see the page we are bookmarking, it's as if we are bookmarking the
bookmark manager. bad semantics.
- we get a sheet even when we already are in the manager so we could respect the
users current selection as destination.

Comment 2

[Chris Petersen]

Agreed. I know this is not common task someone would do. I just noticed this
happens to create a bookmark after I drag it to the bk window. I checked this
behavior in Safari 1.1 as well. When dragging the name field data in their
bookmark window , It appears to ignore this task and won't let you create a
bookmark in this manner.

Comment 3

[Jasper]

Yep that seems to be the behaviour we would want.

Comment 4

[David Haas (gone, not reading mail)]

Attachment: fix

adds a check for objects which are only NSStringPboardType to make sure they
can be turned into valid URL's.  If they can, groovy.  If they can't, punts.

Comment 5

[S Woodside]

I created a new Bug 227297 to disable Add Bookmark while in the bookmark
manager. Renaming this one (was Dragging bookmark name (in sheet) into bookmark
window results in a invalid bookmark).

Comment 6

[Mike Pinkerton (not reading bugmail)]

landed with 227040

Comment 7

[Chris Petersen]

Verified fixed with the 2004010503 NB under 10.2.3