Closed Bug 223702 Opened 17 years ago Closed 13 years ago
_source _mgr*src' might be used uninitialized in ns JPEGDecoder::Init
84. nsJPEGDecoder.cpp:131 (no file match) (See build log excerpt) `decoder_source_mgr*src' might be used uninitialized in this function I read this as: if (mInfo.src) crash();
Is this the same as bug 134556 ?
*** Bug 134556 has been marked as a duplicate of this bug. ***
jpeg_create_decompress() zeros out mInfo.src, so this warning doesn't really apply. We could just remove the test to quiet the compiler.
tor: whichever way you want, note that the second part of the patch should save an op or two
Status: NEW → ASSIGNED
Don't we have NS_ASSERTION? What about removing the "always true" test, but asserting that it's really true? (If we don't build for debugging, the assertions should disappear, shouldn't they?). This seems more safely to me, and shouldn't cost any operating time.
Fixed by Bug 325906: Remove one malloc from the JPEG decoder, and some optimizations.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.