223718 - cssparser has problems to clear the initial state

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Bernd]

The above url asserts at:
 http://lxr.mozilla.org/seamonkey/source/content/html/style/src/nsCSSDataBlock.cpp#820
with a cvs build from 2003-10-24 winxp.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The problem is that setting the 'play-during' property sets values for
eCSSProperty_play_during and eCSSProperty_play_during_flags, but we don't have
play-during in the shorthand table (and it isn't a real shorthand).  We could
either fix this with bz's nsCSSValuePair patch or add a second funny value
(-x-play-during-value) and make it a true shorthand.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Bug 208729 is the bug for the nsCSSValuePair work.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

This fixes the problem by making it a proper shorthand property.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I tested that this makes the rules in
http://www.editions-eyrolles.com/livres/glazman/tests/acss/acss6.htm correct in
DOM Inspector and that a slightly earlier version of it fixes the assertion.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 134197 [details] [diff] [review]
patch

Yeah, this would fix it too...

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2003-10-29 17:50/51 -0800.