223968 - Unify browser.js amd nsContextMenu.js's implementations of isTextSelection and searchSelected

Status: RESOLVED WONTFIX

(SeaMonkey :: UI Design, defect)

Description

[Christian Reis]

Fallout from bug 221361, where Alec suggests unforking these methods. 

http://lxr.mozilla.org/mozilla/source/browser/base/content/browser.js#3478

http://lxr.mozilla.org/seamonkey/source/xpfe/communicator/resources/content/nsContextMenu.js#785

Pierre, do you have an opinion on this -- i.e., is m/b going to morph these
methods away from the current c'np?

Henrik, feel free to unassign yourself if this isn't your piece of cake.

Comment 1

[Pierre Chanial]

Kiko: I don't really get the point.
Firebird is not supposed to rely on mozilla/xpfe.
If this bug is about porting the fix from bug 221361, then that's fine, I can do
the job.

Comment 2

[Christian Reis]

The fix has already been applied to mozilla/browser's browser.js. I was rather
asking if the browser.js version is going to diverge further, or if seamonkey
and m/b share this code (through some other file I can't guess right now)?

Comment 3

[Pierre Chanial]

no the patch has not been applied yet.
See my comment in bug 221361.

Comment 4

[Pierre Chanial]

The suite and Firebird are seperate gecko embeddors. 
Firebird has a well organized tree structure and I don't want to mess it:
there's no way the Firebird context menu stuff would be built outside of
mozilla/browser.
As long as the seamonkey suite lives, its patches will be ported to the
stand-alone apps.
That sucks but I don't see other options.

Comment 5

[Christian Reis]

Fair enough.

Alec, I'm going to WONTFIX this; if you disagree, please reopen (I guess it's
better that way given that you already get enough bugspam as it is to find this
through it).