224126 - taint issues in editkeywords

Status: RESOLVED WORKSFORME

(Bugzilla :: Administration, task)

Description

[Albert Ting]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031021 Firebird/0.7
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031021 Firebird/0.7

Similar to bug 208847, editkeywords has some taint issues.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Albert Ting]

Attachment: patch

I resolved this using the same style as in bug #208847

Comment 2

[Mike Wake]

I just ran into the same problem and fixed the viewing side of things in a
similar way.

But, I don't think that the patch presented in comment #1 goes all the way.

You also have to detaint the keyword "$name" and "$description" in the event of
an "UPDATE".

I came across this while trying to change a keyword.
I have been running 2.17.3 on win2000 with Apache2 and ActivePerl set up in the
following way
*httpd.conf
ScriptInterpreterSource registry
*registry
HKEY_CLASSES_ROOT\.pl\Shell\ExecCGI\Command D:\Perl\bin\Perl.exe -wT "%1" %*

The capital T is the killer.  

Possibly once you've changed the patch for the update case you should probably
also put a -T in the #!/usr/bin/perl -w line. 

Cheers
MikeW

Comment 3

[:glob ✱]

worksforme.  editkeywords contains detaint code now.

not the best way to do it (should use SqlQuote), but that's for another bug.