224346 - can't refresh search tab when search results appear (in advanced mode)

Status: RESOLVED FIXED

(SeaMonkey :: Sidebar, defect)

Description

[Galileo Vidoni]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20030925
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20030925

If you make a search with mutiple search engines (with the sidebar set in
"advanced" mode), there is no form of refreshing it's contents and return to the
stage in which you choose with what search engines you want to search, until you
close mozilla, or choose "Edit Categories" (that's also a bug, "Edit Categories"
erases search results).

Reproducible: Always

Steps to Reproduce:
1.Set the sidebar serach tab to advanced, search something
2.Try to serach for other thing (without closing and reopening mozilla)
3.You can't :-P

Actual Results:  
There is no clean form of searching again

Expected Results:  
Perhaps a "New Search" button, for erasing search results and returning to the
search engine list

Comment 1

[Karsten Düsterloh]

Works for me, at least with 1.7.2, so it was fixed. Advanced search is broken in
1.8aX, but that's a different problem...

Comment 2

[Karsten Düsterloh]

> Advanced search is broken in 1.8aX, but that's a different problem...

Might as well take this bug, since the symptoms are the same and no
investigation was made here... Patch ahead.

Comment 3

[Karsten Düsterloh]

Attachment: use correct uri

With 1.8a4, search was still okay.
Since at least 1.8a5, only the first search produces "real" results, subsequent
searches redisplay the first results.
Digging into the code, it seems that |top| in internetresults.xul isn't able to
leave the <browser> iframe anymore. Hence |top.content| does not reach the
search uri "something" in internetresults.xul?something, but the search results
display pane...
Thus no new search results are shown.

Comment 4

[[e-mail]]

Comment on attachment 169867 [details] [diff] [review]
use correct uri

OK, so what went wrong? The script appears to be written to work either in the
sidebar or in the browser. This means that it needs a way of referencing the
browser; it does this using top.content which usually works. An <iframe
name="content"> used to override this but bug 254284 changed that to <iframe
id="content"> which is what we have in the xul. So now when it is loaded into
the content area it can't find itself because it finds its frame instead.

Comment 5

[Karsten Düsterloh]

Attachment: change confusing id

> OK, so what went wrong? The script appears to be written to work either in
the
> sidebar or in the browser.

internetresults.js is only loaded by internetresults.xul, and especially  
onLoadInternetResults is only used in internetresults.xul.
And (AFAICT) internetresults.xul in turn is always loaded into the browser,
since the "power search" was removed in bug 250637.
I can't find any code (and sense in) loading internetresults.xul into the
sidebar.

> This means that it needs a way of referencing the
> browser; it does this using top.content which usually works. An <iframe
> name="content"> used to override this but bug 254284 changed that to <iframe
> id="content"> which is what we have in the xul. So now when it is loaded into

> the content area it can't find itself because it finds its frame instead.

So changing this ID should be the way to go...
==> new patch.

Comment 6

[Karsten Düsterloh]

JFTR, as a correction to comment #3:
*All* searches fail without the patch, even the first one!
Starting with a fresh profile, no old successful search is found, hence no
results at all. Using a profile that has had a successful search in the past,
every search now redoes that search...

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in xpfe/components/search/resources/internetresults.js;
/cvsroot/mozilla/xpfe/components/search/resources/internetresults.js,v  <-- 
internetresults.js
new revision: 1.44; previous revision: 1.43
done
Checking in xpfe/components/search/resources/internetresults.xul;
/cvsroot/mozilla/xpfe/components/search/resources/internetresults.xul,v  <-- 
internetresults.xul
new revision: 1.80; previous revision: 1.79
done