224723 - NS_ASSERTION(boxObject, "no box object!"); timer fired after tree was destroyed

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[timeless]

Steps:
open history
close history

expected results: nothing interesting

actual results: assertion

+	mTree	0x00000000
  NS_ASSERTION(boxObject, "no box object!");
nsDebug::Assertion(const char * 0x018160e0, const char * 0x018160d4, const char 
* 0x01816090, int 732) line 109
nsTreeSelection::FireOnSelectHandler() line 732 + 38 bytes
nsTreeSelection::SelectCallback(nsITimer * 0x03584a68, void * 0x03504e60) line 
345
nsTimerImpl::Fire() line 382 + 17 bytes
nsTimerManager::FireNextIdleTimer(nsTimerManager * const 0x020784a0) line 616
nsAppShell::Run(nsAppShell * const 0x00c57fe0) line 142
nsAppShellService::Run(nsAppShellService * const 0x00c57f58) line 476
main1(int 3, char * * 0x00444340, nsISupports * 0x00bd0fc0) line 1292 + 32 bytes
main(int 3, char * * 0x00444340) line 1679 + 37 bytes
mainCRTStartup() line 338 + 17 bytes
KERNEL32! SetUnhandledExceptionFilter + 92 bytes

Comment 1

[timeless]

Attachment: cancel the timer if the tree goes away [Checked in: see Comment 5]

Comment 2

[Darin Fisher]

Comment on attachment 134790 [details] [diff] [review]
cancel the timer if the tree goes away
[Checked in: see Comment 5]

i defer to dbaron (or one of the other layout sr's).

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 134790 [details] [diff] [review]
cancel the timer if the tree goes away
[Checked in: see Comment 5]

If you use boolean logic rather than nesting ifs, sr=dbaron.

Comment 4

[Jan Varga [:janv]]

Comment on attachment 134790 [details] [diff] [review]
cancel the timer if the tree goes away
[Checked in: see Comment 5]

maybe you don't need the first condition at all

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 134790 [details] [diff] [review]
cancel the timer if the tree goes away
[Checked in: see Comment 5]


Check in: { 12/20/2003 20:27	timeless%mozdev.org	1.35 }
(with comment 4 suggestion)