225075 - Case-sensitive summary matching does not work

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect, P3)

Description

[Boris Zbarsky [:bzbarsky]]

BUILD: Whatever mozilla.org has right now

STEPS TO REPRODUCE:
1)  Load http://bugzilla.mozilla.org/query.cgi
2)  Type "HEAD" in the "summary" search field
3)  Select "contains the string (exact case)" for the search type
4)  Click "Search"

ACTUAL RESULTS: 460 bugs found, with summaries like "Redesign of header handling"

EXPECTED RESULTS: 2 or 3 bugs found, all with the string "HEAD" in the summary

I _think_ this was working a few weeks ago, so I wonder what changes have been
made to the bugzilla install since then...

Comment 1

[Joel Peshkin]

This problem exists in the tip (2.17.6)+

Comment 2

[Joel Peshkin]

Attachment: Case Sensitivity fix

Comment 3

[Bradley Baetz (:bbaetz)]

Comment on attachment 139341 [details] [diff] [review]
Case Sensitivity fix

Bleh. r=bbaetz

Comment 4

[Dave Miller [:justdave]]

heh, this ain't in the least bit portable...  but I guess we haven't crossed
that bridge yet.

Comment 5

[Joel Peshkin]

Checking in Bugzilla/Search.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search.pm,v  <--  Search.pm
new revision: 1.49; previous revision: 1.48
done

Interestingly, the case-insensitive search converts everything to lower case.  I
that necessary?  Does it prevent the effective use of indices?

Comment 6

[Bradley Baetz (:bbaetz)]

You can't really ue indexes on a substring search. The lower is needed for
SQL-standard databases.

Comment 7

[Dave Miller [:justdave]]

FYI: this patch uses MySQL functions that were introduced in version 4.0.2 and
breaks compatibility with MySQL 3.23.x.

We have two choices:
1) back this out, or
2) bump the minimum MySQL requirement to 4.0.2

Comment 8

[Boris Zbarsky [:bzbarsky]]

If you back this out, please either don't do so on bugzilla.mozilla.org or also
revert whatever change originally caused this bug.  Searching bugzilla was
basically unusable while this bug existed since you'd have to try all the
arbitrary possible capitalizations people use...

Comment 9

[Dave Miller [:justdave]]

bug 243351 has been filed to follow this up.

Comment 10

[Dave Miller [:justdave]]

(In reply to comment #8)
> Searching bugzilla was
> basically unusable while this bug existed since you'd have to try all the
> arbitrary possible capitalizations people use...

uhh, actually, it was the opposite problem.  the "case-sensitive" search was
ignoring case, so you'd still get all the matches anyway.

Comment 11

[Boris Zbarsky [:bzbarsky]]

er... never mind then.  I must have been thinking of a different bug....