22521 - Popup menu doesn't appear when right clicking below bookmarks

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P2)

Description

[Cyril Bortolato]

Steps to reproduce:
1) select Manage Bookmarks in Bookmarks menu. The bookmark window appears.
2) don't select anything
3) right click in the white space below the bookmarks. A dot appears on the
  screen, but no popup menu (I guess it's an empty popup menu). The following
  message appears in the xterm from which mozilla was launched:

JavaScript Error: uncaught exception: [Exception... "Parameter is not an
object"  code: "1003" nsresult: "0x805303eb (NS_ERROR_DOM_NOT_OBJECT_ERR)"
location: "chrome://bookmarks/content/bookmarks.js Line: 749"]


Build & platform:
M12 on Linux

Additional details:
The popup menu content depends on which item has been selected (bookmark,
folder, or separator). The code in fillContextMenu() figures out which commands
to show depending on the selected node's type. So yes, if no item is selected,
the code as it is today cannot determine which commands should be added to
the popup, and we end up with an empty popup menu.
Shouldn't there be a default popup menu in that case? It could contain the
following commands: New Bookmark, New Folder, New Separator.

Comment 1

[don]

Nice catch.

Comment 2

[Steve Lamm]

I would expext is to come up empty.

Comment 3

[Robert John Churchill]

When clicking on the background of either the bookmarks window or the bookmarks 
sidebar panel, some context menu commands are indeed valid:  items such as add 
new bookmark, add new separator, add new folder.

This is now fixed... (although, it depends on bug # 28915 to be fixed before 
selecting context menu commands for bookmarks actually will fire.)

Comment 4

[Claudius Gayle]

VERIFIED with the 2000032809 builds. Bug 24602 is where you end up if you followthe dupe trail that starts at bug 28915