225264 - switch profile after rename fails

Status: RESOLVED WORKSFORME

(SeaMonkey :: Startup & Profiles, defect)

Description

[Asa Dotzler [:asa]]

If you attempt to switch profiles after renaming a profile nothing happens.

Tested with an optimized trunk build from 2003/11/10 on Windows XP.

Steps to reproduce:
1. Tools -> Switch Profile
2. Manage Profiles
3. Rename a profile
4. Select renamed profile and click "Use Profile"

Nothing happens. 

Expected beahvior:
A user should be able to make any changes in the Profile Manager and pick from
any of the available profiles.

Comment 1

[Asa Dotzler [:asa]]

I see this on linux builds from today as well.

If you've got two profile and you rename the one you're not working from and
then try to switch to it, the switch fails. 

Comment 2

[Stefan Borggraefe]

Also happens on Linux.

This was already broken in Mozilla 1.4.

Comment 3

[Asa Dotzler [:asa]]

workaround available. not going to block. I'll try to figure out if this ever
worked. 

Comment 4

[Asa Dotzler [:asa]]

darin or conrad, can either of you take a look at this?

Comment 5

[Conrad Carlen (not reading bugmail)]

> I'll try to figure out if this ever worked.
Also, I wonder if this works when launching the app with multiple profiles using
a build from before profile switching (1.3?)

Comment 6

[Asa Dotzler [:asa]]

This actually works if you access the profile manager at application launch
rather than using the switch profile function from within the browser. I can,
for example, start profilemanager, rename a profile, then start with that or any
other profile. 

Comment 7

[Boying Lu]

Attachment: patch v0

Comment 8

[Boying Lu]

Comment on attachment 142991 [details] [diff] [review]
patch v0

Hi,
  Can you give r?

Comment 9

[Conrad Carlen (not reading bugmail)]

Brian - have you debugged to find the exact point of failure here?

Comment 10

[Conrad Carlen (not reading bugmail)]

Attachment: (Bv1) fixes it at the root

I did some debugging and found the problem is, ForgetCurrentProfile(), which is
called by RenameProfile() does this:

mCurrentProfileAvailable = PR_FALSE;

That horks the next call to SetCurrentProfile() because it then doesn't shut
down the current profile, thinking it doesn't have one. Removing that from
ForgetCurrentProfile() fixes it - it shouldn't be doing that anyway. The rest
of the fix is to not call ForgetCurrentProfile() unconditionally from
RenameProfile().

Comment 11

[Conrad Carlen (not reading bugmail)]

Comment on attachment 142991 [details] [diff] [review]
patch v0

clearing r= request

Comment 12

[Wayne Mery (:wsmwk)]

simple patch never approved nor (obviously) checked in.
was any aspect of this picked up by bug 245135?

Comment 13

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a4pre) Gecko/20070417 SeaMonkey/1.5a] (nightly) (W2Ksp4)

Other steps:
...
3. Rename current profile.
4. "Use Profile" on a different profile.
r. Alert
[
SeaMonkey cannot switch to profile "xyz" automatically.
SeaMonkey will now exit.
Please start SeaMonkey again.
]

At next start, the "current" profile is still selected:
the switch (request) is not remembered.

***

Also the alert (and SeaMonkey) closes/exits as soon as the mouse is moved over it :-(
Should wait for user to (read then) press the button !

Comment 14

[Serge Gautherie (:sgautherie)]

(In reply to comment #13)
> [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a4pre) Gecko/20070417
> SeaMonkey/1.5a] (nightly) (W2Ksp4)
> 
> Other steps:

Well, it seems steps need to be
1. Start a profile
2. Rename another then switch to that one

> 3. Rename current profile.
> 4. "Use Profile" on a different profile.
> r. Alert
> [
> SeaMonkey cannot switch to profile "xyz" automatically.
> SeaMonkey will now exit.
> Please start SeaMonkey again.
> ]
> 
> At next start, the "current" profile is still selected:
> the switch (request) is not remembered.

And, if you start it, the profile has silenty switched from online to offline mode.

Comment 15

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a4pre) Gecko/20070419 SeaMonkey/1.5a] (nightly) (W2Ksp4)

Let's sum up the issues from my 2 previous comments:

A)
I got confused about the steps to reproduce:
in fact, it seems that I can (now) rename profiles as much as I want: maybe fixed by other bug ? (see comment 12)

B)
The steps to get the comment 13 alert is to open MailNews while online and let it check for new mail !
Then, no need to rename any profile, trying to switch is enough.

C)
When B happens:
*the alert is dismissed by the mouse without pressing the button.
*the SM network status change from online to offline.
*my cookies are all deleted: dataloss !

Should I open a "switch profile after checking mail fails" bug about B and C ?

Comment 16

[Philip Chee]

Does this still happen now that trunk is using the toolkit profile manager?

Comment 17

[Serge Gautherie (:sgautherie)]

(In reply to comment #12)
> simple patch never approved nor (obviously) checked in.
> was any aspect of this picked up by bug 245135?

The (checked in) patch there looks partly similar to the one here;
it probably fixed the initial issue.


(In reply to comment #16)
> Does this still happen now that trunk is using the toolkit profile manager?

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081009 SeaMonkey/2.0a2pre] (home, debug default) (W2Ksp4)

I can't reproduce the old issue nor the more recent ones.

R.WorksForMe

Comment 18

[Serge Gautherie (:sgautherie)]

Comment on attachment 143219 [details] [diff] [review]
(Bv1) fixes it at the root

Bug 245135 patch bit-rotted this one,
and probably obsoleted it too :-|