225310 - "Remember as default" should not appear unless logged in

Status: RESOLVED WONTFIX

(Bugzilla :: Query/Bug List, defect)

Description

[Gervase Markham [:gerv]]

The recent changes to the stored query mechanism have left the following
problem. "Remember this as my default search" appears unconditionally; if you
check it when not logged in, you are asked to. Better behaviour, I think, would
be not to display it at all. Your task is searching, and searching doesn't
require a login. Asking for one to save the default just interrupts the user.

The "Remember this search" field on the buglist also appears unconditionally; in
contrast, I think this is the right behaviour, because if you type something in
here and hit "Remember", that is your task, and so going via an account signup
is fine. 

Gerv

Comment 1

[Gervase Markham [:gerv]]

Taking.

Gerv

Comment 2

[Gervase Markham [:gerv]]

Attachment: Patch v.1

This should do it.

Gerv

Comment 3

[Gervase Markham [:gerv]]

Comment on attachment 135443 [details] [diff] [review]
Patch v.1

Quick one for you to review and approve, Dave :-)

Gerv

Comment 4

[Dave Miller [:justdave]]

Do we still care about making cookieless logins work? (however tedious they are)

Although I guess if they are in that situation, they can always do
"GoAheadAndLogIn=1" in their url and get it.

Comment 5

[Gervase Markham [:gerv]]

Hmm. Good point. Yeah, perhaps we should leave the behaviour as-is.

Gerv

Comment 6

[Gervase Markham [:gerv]]

WONTFIX. It's not a major UI win to remove it, and it makes it easier for the
cookieless to have it.

Gerv

Comment 7

[Dave Miller [:justdave]]

mass clearing milestone on DUPLICATE/WONTFIX/WORKSFORME/INVALID so they'll show
up as untriaged if they get reopened.