225453 - JavaScript issues with 0928 and later nightly builds Outline style Table of Contents Script

Status: RESOLVED DUPLICATE of bug 222191

(SeaMonkey :: General, defect)

Description

[Bill Gianopoulos [:WG9s]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6a) Gecko/20030928 Firebird/0.7+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6a) Gecko/20030928 Firebird/0.7+

OUTLINE STYLE TABLE OF CONTENTS in JAVASCRIPT Version 3.0 by Danny Goodman
([e-mail]), does not work with any MozillaFirebird nightly dated 0928
and later.  It works fine with the 0926 MozillaFirebird nightly.  I have also
verified that it fails with the Mozilla suite as well.  This script is used in
the Cisco VPN 3000 concentrator configuration tool.

Reproducible: Always

Steps to Reproduce:
1.  Log onto a Cisco VPN 3000 concentrator via the web admin interface
2.  Click on a "+" in the sidebar menu
3.

Actual Results:  
Nothing.  Javascript errors are reported.

Expected Results:  
Exapnded the menu choices.

Comment 1

[Bill Gianopoulos [:WG9s]]

Attachment: Screenshot of JavaScript Errors

Comment 2

[Bill Gianopoulos [:WG9s]]

Attachment: First script file with js errors

Comment 3

[Bill Gianopoulos [:WG9s]]

Attachment: Second file with js errors

Comment 4

[Bill Gianopoulos [:WG9s]]

Attachment: Third file with js errors

Comment 5

[Phil Schwartau]

William: thank you for such a thorough report! However, this web app
uses a lot of other HTML files we'd need to see to debug this.

Reassigning to Browser-General for now, as this is not likely to 
result from a bug in JS Engine. 

Is there a public website anyone knows of that uses the same script?

Comment 6

[Jon Henry]

I only had a couple seconds to look at this, but in Bonsai there's one
suspicious checkin: bug 165653. It changed how the sidebar is accessed
programmatically, and perhaps broke the script. It caused at least one other
regression, where you couldn't add any search engines.

Comment 7

[Bill Gianopoulos [:WG9s]]

re: comment #5 let me see if I can make up something with just files on my hard
drive to illustrate the issue.

Comment 8

[Phil Schwartau]

cc'ing Chris - (note the error messages in Comment #1 mention sidebar)

Comment 9

[Bill Gianopoulos [:WG9s]]

Hmmm.  Well I did find a public site that uses this script (actually it is the
author's website so it might be a newer version) and that works fine.  I would
certaiinly hope it is NOT the sidebar checkin that broke this as this is just a
frame that happens to be named sidebar and I would certainly hope that the code
in Mozilla is not assuming every frame named sidebar is the mozilla sidebar.

Comment 10

[Bill Gianopoulos [:WG9s]]

Attachment: Tar file contianing pages that exhibit failure

Comment 11

[Bill Gianopoulos [:WG9s]]

Comment on attachment 135357 [details]
Tar file contianing pages that exhibit failure

This attachment is a tar file containing files needed to exhibit the problem. 
It does not disply quite right, but the sidebar manus can be expanded,
contarcted with the MozillaFirebird 9/26 nightly and not swith the 9/28 and
later nightlies.

Comment 12

[Boris Zbarsky [:bzbarsky]]

> is not assuming every frame named sidebar is the mozilla sidebar.

No, but it is assuming that window.sidebar is a Mozilla-internal object....  If
you want the frame named sidebar, window.frames['sidebar'] is at your beck and
call...

Comment 13

[Bill Gianopoulos [:WG9s]]

Hmm.  Well it appears that the fact that the frame is named sidebar definitely
IS the issue.  I changed the frame name and all the script refernces from
'sidebar' to sidebarx' in my saved to local files version, and now the menus
work with the 0928 nightly.

Now the question is how do we get Cisco to change the name of the frame in the
firmware embedded web browser in this product?

Is 'sidebar' now some documented reserved word that refers to the browser
sidebar?  If not, how mush stuff would break if we renamed this to something
more descriptive and less likely to conflict with existing pages like
'browsersidebar' for example?

Or is there some way to recode this fix such that refernces like
top.subframe.sidebar and parent.subframe.sidebar will work like they used to?

Comment 14

[Boris Zbarsky [:bzbarsky]]

Marking dup of shorter bug with clearer explanation....

*** This bug has been marked as a duplicate of 222191 ***