225817 - Support for fileName/lineNumber properties in Error objects

Status: VERIFIED FIXED

(Rhino Graveyard :: Core, enhancement)

Description

[Igor Bukanov]

It would be nice if Rhino would define fileName and lineNumber in error objects
as SpiderMonkey does.

Comment 1

[Igor Bukanov]

Attachment: Fix to pass js1_5/Exceptions/regress-50447.js

Rhino CVS tip already contains code to put fileName and lineNumber properties.
I added that code to ScriptRuntime.getCatchObject together with code to create
JS Error objects from Java exceptions only when scripts catches exceptions. But
it did not help to pass js1_5/Exceptions/regress-50447.js and the patch fixes
that so hopefully the patch makes Rhino matching SpiderMonkey behavior.

Comment 2

[Igor Bukanov]

Attachment: Fixing typo in the patch that caused js1_5/Object/regress-96284-001.js to fail

The SpiderMonkey test suite is awesome!

Comment 3

[Igor Bukanov]

I committed the fix, but I keep the bug open since I think it would be resonable
to add fileName and lineNumber properties to JS objects representing caught Java
execptions.

Comment 4

[Igor Bukanov]

Attachment: Adding fileName and lineNumber for Java execptions

With the patch when I run:

try {
	null.value;
} catch (e) {
	print(format_ex(e));
}

try {
	new java.util.Vector(-1);
} catch (e) {
	print(format_ex(e));
}

function format_ex(e)
{
	return e.fileName+":"+e.lineNumber+": "+e.name+": "+e.message;
}

I get:

/tmp/x.js:2: TypeError: Cannot read property "value" from null
/tmp/x.js:8: JavaException: java.lang.IllegalArgumentException: Illegal
Capacity: -1

The patch adds new exception constructor, JavaException and puts the original
java exception as javaException property of the catch object so the following
would also works:

try {
	new java.util.Vector(-1);
} catch (e if JavaException) {
	e.javaException.printStackTrace();
}

Comment 5

[Igor Bukanov]

I commiteed the last patch.

Comment 6

[Igor Bukanov]

Attachment: Patch to remove skipping of js1_5/Exceptions/regress-50447.js from test suite

With the patches committed the test cases passes fully OK.

Comment 7

[Phil Schwartau]

Thanks, Igor. Patch checked in for rhino-n.tests:

[//d/JS_TRUNK/mozilla/js/tests] cvs ci rhino-n.tests
Checking in rhino-n.tests;
/cvsroot/mozilla/js/tests/rhino-n.tests,v  <--  rhino-n.tests
new revision: 1.57; previous revision: 1.56
done


Marking Verified FIXED. Testcase js1_5/Exceptions/regress-50447.js
above now passes in the Rhino shell, in compiled/interpreted modes.

Comment 8

[Igor Bukanov]

Trageting as resolved against 1.5R5